Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Nov 3, 2025

  • Allow to iterate on particles of level N without a level loop.
  • Allow to access named pure SoA attributes directly on the particle iterator (pti).

New simple interface example:
image

@ax3l ax3l requested review from RemiLehe and dpgrote November 3, 2025 23:18
@ax3l ax3l added the component: particles Particles label Nov 3, 2025
* Allow to iterate on particles of level N without a level
  loop.
* Allow to access named pure SoA attributes directly on
  the particle iterator (`pti`).
Avoid using the deprecated APIs.
@ax3l ax3l force-pushed the topic-pti-simple branch from 163bda5 to 7e0583a Compare November 3, 2025 23:40
@ax3l ax3l mentioned this pull request Nov 3, 2025
Comment on lines +60 to +61
# for lvl in range(self.finest_level + 1):
# yield self.Iterator(self, level=lvl)

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Copy link
Contributor

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two minor comments.

Signed-off-by: Axel Huebl <[email protected]>
Co-authored-by: Roelof Groenewald <[email protected]>
Signed-off-by: Axel Huebl <[email protected]>
@ax3l ax3l enabled auto-merge (squash) November 4, 2025 17:29
@ax3l ax3l merged commit 24fd743 into AMReX-Codes:development Nov 4, 2025
18 checks passed
@ax3l ax3l deleted the topic-pti-simple branch November 4, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants