Skip to content

Always use version tag in pybind11 dependency update #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
+3 −2
Merged

Always use version tag in pybind11 dependency update #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions update_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@ def update(args):
else:
# latest available tag (index 0) for all other dependencies
repo_version_tag = tags_list_filtered[0]["name"]
# use version tag instead of commit sha for a release update
new_commit_sha = repo_version_tag if args.release else repo_commit_sha
# use version tag instead of commit sha for a release update or for pybind11
use_version_tag = args.release or (repo_name == "pybind11")
new_commit_sha = repo_version_tag if use_version_tag else repo_commit_sha
# update commit
if repo_name != "pyamrex":
print(f"- old commit: {dependencies_data[commit_key]}")
Expand Down
Loading