-
Notifications
You must be signed in to change notification settings - Fork 61
Spray: many liquid species to depositing to a single gas species #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d-montgomery
wants to merge
91
commits into
AMReX-Combustion:development
Choose a base branch
from
d-montgomery:many-to-one
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spray: many liquid species to depositing to a single gas species #633
d-montgomery
wants to merge
91
commits into
AMReX-Combustion:development
from
d-montgomery:many-to-one
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges My spray multicomponent changes
This was referenced Nov 20, 2025
Many2one mods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the indexing in the spray module, specifically how liquid spray species deposit to corresponding gas-phase species. The changes include:
SPRAY_FUEL_NUM <= NUM_SPECIESrequirement. This requires molecular weights to be read in from the input file for both the GCM and MP models. Users can now have multiple spray species deposit to a single, or multiple gas-phase species.fdat.indx. This erroneously mapped species to a gas species with the exact same name regardless of howfdat.dep_indxwas defined.fdat.dep_indxThe implementation has been tested with the
SingleDropEvapvalidation cases, specifically WongLin, Daif, and the RungeJP8 tests (see PeleLMeX #593). For the WongLin and Daif cases, a test mechanism was created that mapped multiple species of heptane or decane to a single heptane or decane species (eg. NC7H16_1, NC7H16_2, ... mapped to a single NC7H16).The RungeJP8 case was tested with 67 liquid fuel components mapping to a single Hychem species for POSF10264 with and without Manifold EOS. The figure below shows results comparing the new "many-to-one" capability to a detailed mechanism for POSF10264. The PeleMP cases demonstrate the impact of using different models for saturated vapor pressure. Note that the PeleMP: Antoine Many-to-One and the PeleGCM: Many-to-One are the same because the Antoine coefficients used in the PeleMP model are generated from FuelLib, so both models have effectively the same saturated vapor pressure implementation.
To do:
SPRAY_FUEL_NUM > NUM_SPECIESas long as the molecular weights for each species is provided.SPRAY_FUEL_NUM > NUM_SPECIES (see [PeleLMeX #593](https://github.com/AMReX-Combustion/PeleLMeX/pull/593))SingleDropEvaptests to include many-to-one validation for RungeJP8 (see PeleLMeX #593)