-
Notifications
You must be signed in to change notification settings - Fork 52
Fix authorization issues with mock resources #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Allow CORS for Auth server * Use correct scopes for registration and query APIs of Registry * Relax enforced use of optional Auth features
|
Checked for regressions against nmos-cpp on Windows/Ubuntu with authorization enabled/disabled. |
lo-simon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor suggestions, rest LGTM.
Co-authored-by: Simon Lo <[email protected]>
cristian-recoseanu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, however, I do not have an environment where I can test this change.
After doing some controller testing of nmos-js using authorization the following issues were identified:
The following fixes were introduced: