Start Avahi Daemon for mDNS discovery #884
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterbrightwell
left a comment
peterbrightwell
left a comment
There was a problem hiding this comment.
Reviewed on ARG call 2025-08-27: looks good though would benefit from testing it doesn't have side effects before merging. @garethsb and @jonathan-r-thorpe will investigate.
Contributor
Author
|
Discussed with Jonathan, and will check works on bare metal (where Avahi may be unavailable or already running for example). |
Contributor
|
Successfully checked on Ubuntu 22.04, Ubuntu 24.04 and Windows 2022 that this doesn't cause an error when running the script "bare metal" . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile installs Avahi but the daemon doesn't start automatically. This means that test cases will fail unexpectedly if href properties in the NMOS resources use an mDNS name like "nmos-node.local" rather than an IP address. Some tests report helpful messages, e.g. IS-04-01 test_20_01 message would contain NameResolutionError("...: Failed to resolve 'nmos-node.local' ([Errno -2] Name or service not known)") but others are much less clear about what went wrong.