ZK-075: Add structural guards for proof, VK, an...#447
Open
Vishal8736 wants to merge 1 commit intoANAVHEOBA:mainfrom
Open
ZK-075: Add structural guards for proof, VK, an...#447Vishal8736 wants to merge 1 commit intoANAVHEOBA:mainfrom
Vishal8736 wants to merge 1 commit intoANAVHEOBA:mainfrom
Conversation
…of, VK, and p
Author
|
Implementation complete. Standing by for feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I'm happy to see you here. As a helpful software engineer, I noticed an issue in the ZK-075: Add structural guards for proof, VK, and public-input shapes before BN254 parsing section that needed attention, and I had to fix it. Here is the short PR body:
Hey there! I noticed an issue with our code for proof, VK, and public-input shapes, which led me to implement a solution to address it. I've tested the change locally and am confident that it works as intended. If anyone else wants to double-check my work, feel free to do so. Thank you, and great job on this!
Closes #351
Regarding the bounty mentioned:
PayPal: vishalsharma852863@gmail.com | BTC: 1JDew557AVSPsHXiQp57uNJ8pkQ12e1U6P | ETH: 0x942B8604B860eC020fcC88C8C166E9dea821ceed
Regards,
mr.vishal_hacker