docs(soroban): document royalty_recipient_updated event (#695) - #718
Merged
Eniola3321 merged 2 commits intoAug 1, 2026
Merged
Conversation
The on-chain event emission itself was already implemented (Issue ANYTECHS#672, update_royalty_recipient / emit_royalty_recipient_updated) with token_id, old address, and new address — but it was undocumented in docs/events.md and had no test asserting the event's actual topics/data, only its side effects on storage. Adds a royalty_recipient_updated section to docs/events.md (topics, data, example JSON payload, filter query) matching the existing event docs' format, wires it into the WebSocket/SSE consumption example, and adds it to the event summary table. Adds two tests: one asserting the emitted event's topics/data match the required fields exactly, and one confirming a fresh, correctly-scoped event fires on each successive update (not just the first). Closes ANYTECHS#695 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@giftben1763-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_royalty_recipient/emit_royalty_recipient_updated) withtoken_id, old address, and new address, but it was undocumented indocs/events.mdand had no test asserting the event's actual topics/data (only its side effects on storage).royalty_recipient_updatedsection todocs/events.md— topics, data, example JSON payload, and filter-by-token query — matching the existing event docs' format, wires it into the WebSocket/SSE consumption example at the top of the doc, and adds it to the event summary table at the bottom.test_update_royalty_recipient_emits_event_with_required_fields— decodes the emitted event and asserts topics/data containtoken_id,old_recipient, andnew_recipientexactly.test_update_royalty_recipient_emits_event_on_every_update— confirms a fresh, correctly-scoped event fires on a second update too, not just the first.Note: stacked on #714 (repairs build-breaking merge corruption already on
main). Includes that diff until it merges — the #695-specific work iscontracts/nft-contract/docs/events.mdand the two new tests incontracts/nft-contract/src/test.rs.Closes #695
Test plan
cargo testincontracts/nft-contract— 68 passed, 0 failed