Skip to content

Ccso: Split parameter search into sub-functions - #5336

Merged
yunqingwang1 merged 1 commit into
AOMediaCodec:av2-encfrom
ram-mohan:refactor_ccso
Sep 3, 2026
Merged

Ccso: Split parameter search into sub-functions#5336
yunqingwang1 merged 1 commit into
AOMediaCodec:av2-encfrom
ram-mohan:refactor_ccso

Conversation

@ram-mohan

Copy link
Copy Markdown
Contributor
  • Split per-plane ccso parameter search into focused sub-functions.
  • Introduce CcsoCtx/CcsoCtxCommon to carry per-plane-search state, replacing long function-argument lists.
  • Replace raw memset/memcpy with av2_zero_array/av2_copy_array, and narrow several of them from the full CCSO_BAND_NUM/ CCSO_CLASS_STATS_ENTRIES range down to the max_band/ max_edge_interval range actually used by the current search iteration.
  • corrects two places that used the horizontal filter-unit log2 for a vertical quantity (derive_blk_md(), get_sb_reuse_dist() and ccso_compute_class_err).

no stats changed

@ram-mohan
ram-mohan force-pushed the refactor_ccso branch 2 times, most recently from a250ecd to 2d11c2e Compare August 29, 2026 20:49
@ram-mohan
ram-mohan marked this pull request as ready for review August 31, 2026 05:37
@urvangjoshi
urvangjoshi requested a review from leolzhao August 31, 2026 18:08
@ram-mohan

Copy link
Copy Markdown
Contributor Author

@yunqingwang1 @urvangjoshi when you get a chance can you please review
cc: @harishdm @ranjit-tulabandu @cherma-a @deepa-kg @RemyaPrakasan @vikasprasad10

Comment thread av2/encoder/pickccso.c
@urvangjoshi

Copy link
Copy Markdown
Contributor

av2-enc branch itself was updated (rebased). Pls rebase your PR.

- Split per-plane ccso parameter search into focused sub-functions.
- Introduce CcsoCtx/CcsoCtxCommon to carry per-plane-search state,
  replacing long function-argument lists.
- Replace raw memset/memcpy with av2_zero_array/av2_copy_array, and
  narrow several of them from the full CCSO_BAND_NUM/
  CCSO_CLASS_STATS_ENTRIES range down to the max_band/
  max_edge_interval range actually used by the current search
  iteration.
- corrects two places that used the horizontal filter-unit log2 for a
  vertical quantity (derive_blk_md(), get_sb_reuse_dist() and
  ccso_compute_class_err).

no stats changed
@yunqingwang1
yunqingwang1 merged commit 4ced699 into AOMediaCodec:av2-enc Sep 3, 2026
107 checks passed
@ram-mohan
ram-mohan deleted the refactor_ccso branch September 3, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants