Skip to content

unused var: Remove few unused fields/structs from av2 encoder - #5355

Merged
urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
SamuthirikaS:cleanup
Sep 3, 2026
Merged

unused var: Remove few unused fields/structs from av2 encoder#5355
urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
SamuthirikaS:cleanup

Conversation

@SamuthirikaS

Copy link
Copy Markdown
  • Intra txb rd hash is removed in commit a7bbe6a. Fields associated with them are now being removed.
  • Inter txb rd hash is disabled in commit e56083f and removed in commit 968c494. Fields associated with them are now being removed
  • Remove TXB_RD_INFO/TXB_RD_RECORD subsystem
  • MB_RD_INFO.*
  • ModeCosts.*
  • LV_MAP_COEFF_COST.* is introduced and used by 6780aa9(CWG-E092 Trellis Coded Quantization). TCQ SW cleanup has deleted the file that access this.
  • PartitionSearchInfo.variance_low
  • RD_SEARCH_MACROBLOCK_CONTEXT.*
  • SimpleMotionData.mv_ref
  • SimpleMotionDataBufs.b_4x64_0/b_64x4_0/b_4x64_1/b_64x4_1
  • CODING_CONTEXT
  • RD_RECT_PART_WIN_INFO
  • MACROBLOCK.skip_mode
  • encode_b_args.ctx
  • ToolCfg.enable_cfl_intra
  • AV2EncoderConfig.operating_points_count
  • TWO_PASS.frame_stats_next_idx
  • tcq_param_t.txb_ctx
  • RestSearchCtxt.tile_y0
  • QUANT_PARAM.tx_size
  • PICK_MODE_CONTEXT.parent/index
  • RefFrameDistanceInfo.nearest_past_ref/nearest_future_ref
  • RATE_CONTROL.*
  • EncodeFrameParams.primary_ref_frame
  • ExternalFlags.cross_frame_context
  • TPL_SPEED_FEATURES.disable_gop_length_decision

@SamuthirikaS
SamuthirikaS marked this pull request as ready for review September 2, 2026 17:16
@SamuthirikaS

Copy link
Copy Markdown
Author

@yunqingwang1 @urvangjoshi
/cc @vikasprasad10 @harishdm @ranjit-tulabandu @cherma-a @deepa-kg @RemyaPrakasan @ram-mohan
We have verified that this PR is bit-exact for speeds 0 to 3 across RA, LD, and AI configurations wrt commit 2ab55a5. Please review.

@urvangjoshi

Copy link
Copy Markdown
Contributor

av2-enc branch itself was updated (rebased). Pls rebase your PR.

@urvangjoshi

Copy link
Copy Markdown
Contributor

Great cleanup. Thanks!

- Intra txb rd hash is removed in commit a7bbe6a, fields associated
  with them are now being removed.
- Inter txb rd hash is disabled in commit e56083f and removed in commit
  968c494, fields associated with them are now being removed.
- Remove TXB_RD_INFO/TXB_RD_RECORD subsystem
- MB_RD_INFO.*
- ModeCosts.*
- LV_MAP_COEFF_COST.* is introduced and used by 6780aa9(CWG-E092
  Trellis Coded Quantization). TCQ SW cleanup has deleted the file that
  access this.
- PartitionSearchInfo.variance_low
- RD_SEARCH_MACROBLOCK_CONTEXT.*
- SimpleMotionData.mv_ref
- SimpleMotionDataBufs.b_4x64_0/b_64x4_0/b_4x64_1/b_64x4_1
- CODING_CONTEXT
- RD_RECT_PART_WIN_INFO
- MACROBLOCK.skip_mode
- encode_b_args.ctx
- ToolCfg.enable_cfl_intra
- AV2EncoderConfig.operating_points_count
- TWO_PASS.frame_stats_next_idx
- tcq_param_t.txb_ctx
- RestSearchCtxt.tile_y0
- QUANT_PARAM.tx_size
- PICK_MODE_CONTEXT.parent/index
- RefFrameDistanceInfo.nearest_past_ref/nearest_future_ref
- RATE_CONTROL.*
- EncodeFrameParams.primary_ref_frame
- ExternalFlags.cross_frame_context
- TPL_SPEED_FEATURES.disable_gop_length_decision
@urvangjoshi
urvangjoshi merged commit ee0b4ba into AOMediaCodec:av2-enc Sep 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants