Conversation
Member
Author
|
Tested with cURL 
|
jiegec
reviewed
May 27, 2026
| packages: String, | ||
| arch: String, | ||
| creation_time: chrono::DateTime<chrono::Utc>, | ||
| #[serde(with = "chrono::serde::ts_seconds")] |
Member
There was a problem hiding this comment.
Why is it required, when creation_time is already present?
Member
Author
There was a problem hiding this comment.
creation_time is a string while serializing as an integer makes parsing eaiser. nevertheless, i doubt myself when looking back at the code. maybe this can be reverted
Member
|
LGTM in general, but would like to see more testing results, e.g. if multiple clients may work at the same time. Also, maybe we can merge formatting changes early? |
It is used in code but not defined in dependency.
- Prepares for the upcoming SSE feed. - Allows to retrieve JobInfoResponse without wrapping with a HTTP request. - Adds UNIX-seconds-style variants for timestamps.
- Prepares for the upcoming SSE feed. - Allows to retrieve PipelineInfoResponse without wrapping with a HTTP request. - Adds UNIX-seconds-style variants for timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a
/api/feedendpoint which allows clients to subscribe to server activities through SSE.This makes creating alternative bot implementation (e.g. IRC bot) easier.