-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to add the candidates while creating election #73 #125
Conversation
added-add-candidates-functionality
@Ronnieraj37 could you review the pr and tell if any changes are required |
Hey @rairohit17 Pl add a check for _candidates .length >= 2 in the createElection from the solidity side. So that we do not have bots creating empty elections from block explorer. |
hey @Ronnieraj37 i have added a check for _candidates.length>2 also i have added a warning for the same in frontend Apart from that i have updated all tests and made them compatible with the contract's changes |
Hey @rairohit17 the changes look good. Just fix the merge conflicts! |
@Ronnieraj37 resolved all merge conflicts |
resolves #73
. changed the createElection functions parameters to pass a candidates array upon initialization
. created suitable frontend changes to allow users to add , remove ,update candidates while creating an election
. updated tests so that they do not fail due to change in contract 's function
Screen.Recording.2025-02-04.231854.mp4
. made sure all tests pass
Screen.Recording.2025-02-05.002541.mp4