Fix #137 Chnaged backend url to localhost:5000 and updated docs to metion adb …#145
Fix #137 Chnaged backend url to localhost:5000 and updated docs to metion adb …#145DeveloperAmrit wants to merge 3 commits intoAOSSIE-Org:mainfrom
Conversation
📝 WalkthroughWalkthroughStandardizes frontend API host usage by importing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
Backend/chroma_db/chroma.sqlite3Backend/my_chroma_db/chroma.sqlite3Frontend/.envFrontend/android/app/src/main/AndroidManifest.xmlFrontend/src/services/ConversationContext.js
🔇 Additional comments (3)
Frontend/src/services/ConversationContext.js (3)
318-320: LGTM: Consistent use of centralized BASE_URL.The delete operation correctly uses the imported BASE_URL, eliminating the hardcoded endpoint that caused the original network failure.
355-359: LGTM: Consistent use of centralized BASE_URL.The update operation correctly uses the imported BASE_URL, maintaining consistency with the centralized configuration approach.
6-7: Good: BASE_URL centralization is comprehensive across the codebase.Importing BASE_URL from environment variables is consistently applied throughout the Frontend—no hardcoded endpoints remain, and all 21 component and service files follow the standardized pattern. This aligns with the PR objective of addressing issue #137.
modified: Setup.md
Added instructions for starting the API and adb reverse command.
|
Hi @DeveloperAmrit tip : |
|
@Naren456 This PR is to solve a critical issue which prevents frontend from talking to backend. I am also working on the backend. |
|
@DeveloperAmrit |
…reverse command
Closes #137
📝 Description
Updated frontend .env file
Updated Frontend/src/services/ConversationContext.js
Updated Frontend/android/app/src/main/AndroidManifest.xml
Updated documentation
🔧 Changes Made
📷 Screenshots or Visual Changes (if applicable)
🤝 Collaboration
Collaborated with:
@username(optional)✅ Checklist
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.