Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PR #122 UI Loader #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ishaanxgupta
Copy link

Hi @Aditya062003,

This PR restores the changes from PR #122 which was reverted by @Aditya062003
Kindly review and merge

Thanks

@ishaanxgupta
Copy link
Author

@Aditya062003
Please review.

@Aditya062003
Copy link
Contributor

Hey, pls mimic these changes for the extension too.

@ishaanxgupta
Copy link
Author

@Aditya062003
Surely, I understand that changes are required for the extension as well. Since this PR addresses the website specifically, would it be possible to merge it first? I will then promptly raise a separate PR to implement the necessary updates for the extension.

@Roaster05
Copy link
Contributor

@ishaanxgupta #152 please look into the comment i recently made, also we would expect all the changes to be iteratively made for the extension as well

@ishaanxgupta
Copy link
Author

Sure

@ishaanxgupta #152 please look into the comment i recently made, also we would expect all the changes to be iteratively made for the extension as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants