fix: unbreak Python Tests after PR #38 json= client.request - #41
Conversation
PR #38 started passing json= to client.request(); outdated mocks rejected it and broke Python Tests on main (23 failures). Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughThe test mock clients now accept arbitrary keyword arguments. Existing route lookup, response construction, response sequences, and exception behavior remain unchanged. ChangesMock Request Compatibility
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
GitHubRestAdaptercalls_client.request(..., json=json_body).method/path/params, so CI onmainfailed with 23TypeError: unexpected keyword argument 'json'.**kwargs(same pattern astest_open_prs_search.py).Test plan
pytest tests/test_github_retry.py tests/test_github_rate_limit.py tests/test_github_ingestion_comments.py tests/test_github_ingestion_lifecycle_events.pymainMade with Cursor
Summary by CodeRabbit