-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor use generic app bar over all app screens ✅ #238
Merged
mdmohsin7
merged 15 commits into
AOSSIE-Org:develop
from
kareemabdeen:enhancement/use-generic-app-bar-over-all-app-screens
Feb 3, 2025
Merged
Refactor use generic app bar over all app screens ✅ #238
mdmohsin7
merged 15 commits into
AOSSIE-Org:develop
from
kareemabdeen:enhancement/use-generic-app-bar-over-all-app-screens
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use generic app bar over popular monuments view mobile
…ly with profile screen
…e app bar Use generic app bar in discover view mobile
…ith about screen use case
@mdmohsin7 Can you please check this PR?🙏🏼 |
mdmohsin7
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a reusable
CustomMobileAppBar
widget to improve the app bar's flexibility and reusability across the Monumento app. The widget now supports dynamic logos, actions, and leading widgets, allowing for consistent design and functionality.Type of change
Current app view
WhatsApp.Video.2025-01-25.at.5.12.50.PM.mp4
How Has This Been Tested?
CustomMobileAppBar
displays the logo correctly when provided.IconButton
widgets.leading
andactions
when they arenull
.Checklist:
Maintainer Checklist