Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the alert dialog issue in deskotop view #243

Merged

Conversation

HelloSniperMonkey
Copy link
Contributor

Description

previously i was unable to press cancel and check-in in the alert box that poped up after pressing the checkin button in monument view because the alert box was too small and and the button was placed outside it causing overflow issue also now there is no overflow issue and i am also able to checkin with my current position

Fixes #242

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

this has been tested on mobile view, desktop view and using macOS as a target build and it works on all three cases

Please include screenshots below if applicable.

Screen.Recording.2025-01-26.at.10.27.49.PM.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@HelloSniperMonkey
Copy link
Contributor Author

can you please review ? @mdmohsin7

Copy link
Collaborator

@mdmohsin7 mdmohsin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdmohsin7 mdmohsin7 merged commit 1d27944 into AOSSIE-Org:develop Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to checkin in desktop view
2 participants