Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signup Screen Layout Overflow Fixes #244 #245

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

xkaper001
Copy link
Contributor

@xkaper001 xkaper001 commented Jan 27, 2025

Description

This PR addresses the layout issues in the SignUpViewDesktop widget by adding constraints to the Column widget within a SingleChildScrollView. The changes ensure that the Column can take as much space as it needs without causing layout errors.

Fixes #244

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested for all view desktop views.

image

Monumento.-.Google.Chrome.2025-01-27.20-33-05.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@xkaper001 xkaper001 requested a review from jddeep as a code owner January 27, 2025 16:05
@xkaper001 xkaper001 changed the title Signup Screen Layout Overflow Fixes #244 fix: Signup Screen Layout Overflow Fixes #244 Jan 29, 2025
Copy link
Collaborator

@mdmohsin7 mdmohsin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdmohsin7 mdmohsin7 merged commit 653fac3 into AOSSIE-Org:develop Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Signup Screen Layout Overflow
2 participants