Skip to content

Fix: Application controls in settings page (#817) #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aurthitaacharya-afk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Application controls in settings page (#817) #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
498e974
Update README
aurthitaacharya-afk Dec 31, 2025
fe9e137
Fix text padding and Line-height to prevent cut off text
aurthitaacharya-afk Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ PictoPy is an advanced desktop gallery application that combines the power of Ta

&nbsp;&nbsp;&nbsp;<a href="https://discord.gg/hjUhu33uAn"><img src="https://github.com/user-attachments/assets/3ed93273-5055-4532-a524-87a337a4fbba" height="40"></a>

1. First, join the **[Discord Server](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
1. First, join the **[ DISCORD SERVER ](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove spaces inside link text brackets.

The spaces in [ DISCORD SERVER ] trigger markdownlint MD039 (no-space-in-links) and may render incorrectly in some Markdown parsers.

Proposed fix 
-1. First, join the **[ DISCORD SERVER ](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
+1. First, join the **[DISCORD SERVER](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
1. First, join the **[ DISCORD SERVER ](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
1. First, join the **[DISCORD SERVER](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone.
🧰 Tools
🪛 markdownlint-cli2 (0.20.0)

[warning] 9-9: Spaces inside link text

(MD039, no-space-in-links)

[warning] 9-9: Spaces inside link text

(MD039, no-space-in-links)

🤖 Prompt for AI Agents 
In `@README.md` at line 9, Remove the extra spaces inside the link text brackets
so the markdown link reads [DISCORD SERVER](https://discord.gg/hjUhu33uAn)
instead of [ DISCORD SERVER ](...); update any other links in README.md that
have spaces inside their bracketed text (e.g., change "[ SOME LINK ]" to "[SOME
LINK]") to satisfy markdownlint MD039 and ensure consistent rendering.

2. For detailed setup instructions, coding guidelines, and the contribution process, please check out our [CONTRIBUTING.md](./CONTRIBUTING.md) file.

# Architecture
Expand Down
12 changes: 12 additions & 0 deletions docs/stylesheets/extra.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,18 @@
}
}

/* fix text padding issue -prevent letters from bring cut off */
button,
input,
select,
textarea,
.md-typeset p,
.md-typeset li {
line-height : 1.5;
padding-top: 0.4rem;
padding-bottom :0.4 rem;
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Invalid CSS value: 0.4 rem — the space breaks the declaration.

0.4 rem is not a valid CSS length; the browser will ignore this entire declaration. Remove the space so it reads 0.4rem.

Proposed fix 
-  padding-bottom :0.4 rem;
+  padding-bottom: 0.4rem;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
padding-bottom :0.4 rem;
padding-bottom: 0.4rem;
🤖 Prompt for AI Agents 
In `@docs/stylesheets/extra.css` at line 324, The CSS declaration "padding-bottom
:0.4 rem;" is invalid because of the space between the number and unit; locate
the "padding-bottom :0.4 rem" declaration in docs/stylesheets/extra.css (look
for the exact "padding-bottom" line) and remove the space so the value is a
valid length (e.g., "0.4rem"); ensure there are no other occurrences with the
same space issue and keep spacing around the colon consistent (padding-bottom:
0.4rem;).

}
Comment on lines +315 to +325
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Overly broad selectors may cause unintended layout changes across all documentation pages.

Applying padding-top/padding-bottom and line-height to every button, input, select, textarea, .md-typeset p, and .md-typeset li globally will affect the entire MkDocs site, not just the settings page. Consider scoping these rules to a more specific selector (e.g., a wrapper class) to avoid unintended side effects on other pages.

Also, the comment on line 315 has a typo: "bring" → "being".

Proposed scoped fix (example) 
-/* fix text padding issue -prevent letters from bring cut off */
-button,
-input,
-select,
-textarea,
-.md-typeset p,
-.md-typeset li {
-  line-height : 1.5;
-  padding-top: 0.4rem;
-  padding-bottom :0.4 rem;
-}
+/* fix text padding issue — prevent letters from being cut off */
+.md-typeset p,
+.md-typeset li {
+  line-height: 1.5;
+  padding-top: 0.4rem;
+  padding-bottom: 0.4rem;
+}

If button/input/select/textarea also need the fix, scope them under a specific page or component class rather than applying globally.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
/* fix text padding issue -prevent letters from bring cut off */
button,
input,
select,
textarea,
.md-typeset p,
.md-typeset li {
line-height : 1.5;
padding-top: 0.4rem;
padding-bottom :0.4 rem;
}
/* fix text padding issue — prevent letters from being cut off */
.md-typeset p,
.md-typeset li {
line-height: 1.5;
padding-top: 0.4rem;
padding-bottom: 0.4rem;
}
🤖 Prompt for AI Agents 
In `@docs/stylesheets/extra.css` around lines 315 - 325, The current global rule
targeting button, input, select, textarea, .md-typeset p, and .md-typeset li
applies line-height and padding site-wide and contains a typo in the comment and
a malformed value ("0.4 rem"); change the comment to "being" and scope the CSS
to a page/component wrapper (e.g., replace the selector with a specific wrapper
like .settings-page button, .settings-page input, .settings-page select,
.settings-page textarea, .settings-page .md-typeset p, .settings-page
.md-typeset li) so these styles only affect the intended page/component, and fix
the padding-bottom value to "0.4rem" and keep line-height: 1.5 as needed.


\
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Stray backslash \ is invalid CSS and will cause parse errors.

This lone \ on line 327 will break CSS parsing and may prevent all subsequent rules (e.g., the footer styles below) from being applied. Remove it.

Proposed fix 
-\
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
\
🧰 Tools
🪛 Biome (2.3.14)

[error] 326-327: unexpected character \

(parse)

🪛 Stylelint (17.2.0)

[error] 327-327: Unexpected unknown type selector "" (selector-type-no-unknown)

(selector-type-no-unknown)

🤖 Prompt for AI Agents 
In `@docs/stylesheets/extra.css` at line 327, Remove the stray backslash character
'\' that is present alone in the stylesheet (it breaks CSS parsing); locate the
lone '\' in the CSS file and delete it so subsequent rules (e.g., the footer
styles) parse correctly, and scan the file for any other stray characters or
stray escape sequences to ensure no additional parse errors remain.

.md-footer-meta__inner.md-grid {
display: flex !important;
Expand Down