Skip to content

fix: resolve local dependency context for root package.json scripts (Fixes #1451) - #1462

Open
KeerthiKumarR wants to merge 1 commit into
AOSSIE-Org:mainfrom
KeerthiKumarR:fix-1451-root-scripts
Open

fix: resolve local dependency context for root package.json scripts (Fixes #1451)#1462
KeerthiKumarR wants to merge 1 commit into
AOSSIE-Org:mainfrom
KeerthiKumarR:fix-1451-root-scripts

Conversation

@KeerthiKumarR

@KeerthiKumarR KeerthiKumarR commented Aug 5, 2026

Copy link
Copy Markdown

Fixes #1451

Problem

The root package.json provided scripts for linting and formatting (lint:check, lint:fix, format:check, format:fix), but they executed binaries like eslint and prettier directly after changing directory. If developers didn't have eslint or prettier installed globally, the commands failed with command not found, despite the packages existing in frontend/node_modules.

Summary of Changes

Updated root package.json scripts to delegate to npm run <script> --prefix frontend. This leverages npm's built-in binary resolution to correctly locate the local node_modules/.bin inside the frontend directory.

Summary by CodeRabbit

  • Chores
    • Updated linting and formatting commands for more consistent frontend project execution.

Copilot AI lite review requested due to automatic review settings August 5, 2026 14:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f8e213df-1158-4ccd-816e-2629aa08d559

📥 Commits

Reviewing files that changed from the base of the PR and between 5b4c41d and c930757.

📒 Files selected for processing (1)
  • package.json

Walkthrough

The root package.json lint and formatting scripts now delegate to the corresponding frontend npm scripts with --prefix frontend.

Changes

Frontend script delegation

Layer / File(s) Summary
Root script wiring
package.json
The lint and formatting scripts now invoke frontend npm scripts through --prefix frontend instead of directly running ESLint and Prettier from a changed directory.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: copilot, rohan-pandeyy

Poem

A rabbit hops through scripts bright,
Frontend tools now run just right.
No global path to chase or find,
npm keeps the workspace aligned.
Lint and format leap in line!

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the dependency-context fix for root package.json scripts and references issue #1451.
Linked Issues check ✅ Passed The changes update the root lint and format scripts to use frontend-local dependencies, which meets issue #1451.
Out of Scope Changes check ✅ Passed The changes are limited to the root package.json lint and formatting scripts and match the linked issue scope.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitcordapp

gitcordapp Bot commented Aug 5, 2026

Copy link
Copy Markdown

Link your account with Gitcord

Thanks for opening this PR, @KeerthiKumarR!

To receive Discord notifications and contributor tracking for this organization:

  1. Join Discord: https://discord.gg/hjUhu33uAn
  2. In Discord, run /link KeerthiKumarR
  3. Paste the verification code into your GitHub bio (or a public gist)
  4. Click Verify in Discord (or run /verify-link KeerthiKumarR)

Once linked, Gitcord can notify you about reviews, merges, and more.

Posted by Gitcord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Root package.json scripts (lint/format) fail due to missing local dependency context

2 participants