-
Notifications
You must be signed in to change notification settings - Fork 172
Feat: Workflow/Pipeline for executables #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pranav0-0Aggarwal
merged 22 commits into
AOSSIE-Org:main
from
rahulharpal1603:feat/workflow-for-executables
Feb 2, 2025
Merged
Feat: Workflow/Pipeline for executables #271
Pranav0-0Aggarwal
merged 22 commits into
AOSSIE-Org:main
from
rahulharpal1603:feat/workflow-for-executables
Feb 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/workflow-for-executables
…feat/workflow-for-executables
@Pranav0-0Aggarwal Please review this. The workflows are ready. |
For MacOS installation we need to follow these steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138
Many new things were introduced, so I drew diagrams to explain everything simply.
This workflow will generate these three formats of installers:
I have tested each installer on their platforms. I will be making guides to install this packages for each platform.
Major Changes:
Problem solved by this PR:
The end-user doesn't need to worry about whether the FastAPI server is running. The Tauri app will handle it using plugins provided by Tauri, which provide an interface to execute terminal commands and run the server. Also, the end user doesn't need to have Python installed on their system, all thanks to PyInstaller, because of which all the dependencies are packaged along with the PictoPy Installer.
Interaction diagram of the Tauri app and the FastAPI server:
Description about the app-build.yml workflow:
This workflow runs three parallel jobs, one for each platform, to generate the FastAPI server's executables. Once these executables are generated, they are temporarily stored and later accessed by the Tauri build workflow. This workflow is derived from this base structure: https://github.com/tauri-apps/tauri-action/blob/dev/examples/publish-to-auto-release.yml
The Final result is that we get a release on GitHub containing all the files for each platform. Example: https://github.com/rahulharpal1603/PictoPy/releases/tag/app-v0.0.0
Diagrammatic Representation of the Workflow: