Fixed face inconsistency after folder removal #572
Closed
DecodeX15 wants to merge 5 commits intoAOSSIE-Org:mainfrom
Closed
Fixed face inconsistency after folder removal #572DecodeX15 wants to merge 5 commits intoAOSSIE-Org:mainfrom
DecodeX15 wants to merge 5 commits intoAOSSIE-Org:mainfrom
Conversation
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughAdds wheel-based zoom handling to media viewer, updates image styling constraints, and adjusts FaceCollections to filter zero-face clusters and dispatch during render instead of useEffect. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User
participant MV as MediaView (container)
participant HC as useImageViewControls (handlers)
participant IV as ImageViewer (image)
U->>MV: Mouse wheel event
MV->>HC: handlers.handleWheelZoom(e, container.getBoundingClientRect())
activate HC
HC->>HC: Prevent default, calc mouse pos, clamp scale
HC->>HC: Adjust pan to keep cursor focal point
HC-->>MV: Update view state (scale, x, y)
deactivate HC
MV->>IV: Rerender with updated transform/style
IV-->>U: Image zooms around cursor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
fix(#569): remove clusters with zero face_count from persisted face data
Description:
This PR filters out clusters where face_count === 0 before updating the main array.
Uploading Recording 2025-10-07 095004.mp4…
Summary by CodeRabbit