Skip to content

Fixed face count inconsistency after folder removal #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DecodeX15 wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Fixed face count inconsistency after folder removal #573

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
24dba76
add new filter array
DecodeX15 Oct 7, 2025
ae9de04
fix linting error
DecodeX15 Oct 7, 2025
30e6eb4
remove console
DecodeX15 Oct 7, 2025
f49e63e
update branch
DecodeX15 Oct 20, 2025
324fff5
adding
DecodeX15 Oct 23, 2025
079b034
branch update
DecodeX15 Oct 24, 2025
34c3cba
update fork
DecodeX15 Oct 28, 2025
0aa0c31
update
DecodeX15 Oct 29, 2025
4698587
conflists
DecodeX15 Oct 30, 2025
b05919e
update
DecodeX15 Oct 30, 2025
85cb38c
add
DecodeX15 Oct 31, 2025
324e5ca
fix zero face count at db lvl
DecodeX15 Oct 31, 2025
a1e29dc
chore: auto-format with black
DecodeX15 Oct 31, 2025
7dfaa3a
update branch
DecodeX15 Nov 13, 2025
ea5ae3b
add
DecodeX15 Nov 15, 2025
c1cb57c
update main branch
DecodeX15 Nov 16, 2025
bc230b1
add
DecodeX15 Nov 16, 2025
c712193
Merge branch 'main' of https://github.com/AOSSIE-Org/PictoPy
DecodeX15 Dec 8, 2025
652964d
Merge branch 'main' of https://github.com/Vaibhaviitian/PictoPy-os in…
DecodeX15 Dec 8, 2025
ca27769
update main branch
DecodeX15 Dec 30, 2025
cffe551
update branch
DecodeX15 Dec 30, 2025
3b00ea2
update main
DecodeX15 Jan 25, 2026
11f1dd3
add
DecodeX15 Jan 25, 2026
1045902
update branch
DecodeX15 Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions frontend/src/components/FaceCollections.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@ export function FaceCollections() {
});

useEffect(() => {
if (clustersSuccess && clustersData?.data?.clusters) {
const clusters = (clustersData.data.clusters || []) as Cluster[];
dispatch(setClusters(clusters));
}
}, [clustersData, clustersSuccess, dispatch]);
if (clustersSuccess && clustersData?.data?.clusters) {
const clusters = (clustersData.data.clusters || []) as Cluster[];

const filteredClusters = clusters.filter(c => c.face_count > 0);

dispatch(setClusters(filteredClusters));
console.log(filteredClusters);
}
}, [clustersData, clustersSuccess, dispatch]);
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Filtering logic is correct; remove console.log and improve variable naming.

The core fix correctly filters out clusters with face_count === 0, which addresses the stated objective of preventing face data persistence after folder removal.

However:

  1. Remove the console.log on line 30 before merging to production. Logging filtered data is helpful during development but should not ship to users.

  2. The local variable clusters on line 25 shadows the Redux state variable from line 16, making the code harder to follow. Consider renaming the local variable to allClusters or fetchedClusters.

  3. The || [] fallback on line 25 is redundant since line 24 already ensures clustersData?.data?.clusters exists via optional chaining.

Apply this diff to address the issues:

  useEffect(() => {
   if (clustersSuccess && clustersData?.data?.clusters) {
-    const clusters = (clustersData.data.clusters || []) as Cluster[];
+    const fetchedClusters = clustersData.data.clusters as Cluster[];

-    const filteredClusters = clusters.filter(c => c.face_count > 0);
+    const filteredClusters = fetchedClusters.filter(c => c.face_count > 0);

     dispatch(setClusters(filteredClusters));
-    console.log(filteredClusters);
   }
 }, [clustersData, clustersSuccess, dispatch]);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
useEffect(() => {
if (clustersSuccess && clustersData?.data?.clusters) {
const clusters = (clustersData.data.clusters || []) as Cluster[];
dispatch(setClusters(clusters));
}
}, [clustersData, clustersSuccess, dispatch]);
if (clustersSuccess && clustersData?.data?.clusters) {
const clusters = (clustersData.data.clusters || []) as Cluster[];
const filteredClusters = clusters.filter(c => c.face_count > 0);
dispatch(setClusters(filteredClusters));
console.log(filteredClusters);
}
}, [clustersData, clustersSuccess, dispatch]);
useEffect(() => {
if (clustersSuccess && clustersData?.data?.clusters) {
const fetchedClusters = clustersData.data.clusters as Cluster[];
const filteredClusters = fetchedClusters.filter(c => c.face_count > 0);
dispatch(setClusters(filteredClusters));
}
}, [clustersData, clustersSuccess, dispatch]);
🤖 Prompt for AI Agents 
In frontend/src/components/FaceCollections.tsx around lines 23 to 32, remove the
development console.log call, rename the local variable `clusters` to
`fetchedClusters` (or `allClusters`) to avoid shadowing the Redux state
variable, and eliminate the redundant `|| []` fallback since the optional
chaining already guarantees the existence check; then dispatch the filtered
results using the new variable name.



const handlePersonClick = (clusterId: string) => {
navigate(`/person/${clusterId}`);
Expand Down
Loading