Fix: use Link component to prevent page reload flash#637
Fix: use Link component to prevent page reload flash#637srijan2607 wants to merge 1 commit intoAOSSIE-Org:mainfrom
Conversation
WalkthroughReplaces standard HTML anchor tags with React Router Link components in the Navbar component for internal page navigation. Adds import statement for Link from react-router and updates two navigation links (logo and settings) to use client-side routing instead of full page reloads. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
Related issue #637 |
|
|
|
releted issue #636 |
|
@rahulharpal1603 can you take a look |
This pull request primarily updates the
peerproperty for several dependencies in thefrontend/package-lock.jsonfile and refactors navigation in theNavbarcomponent to use React Router'sLinkinstead of anchor tags. These changes improve dependency management and ensure proper client-side routing in the application.Dependency management improvements:
"peer": trueproperty to many dependencies infrontend/package-lock.jsonto correctly indicate peer dependencies, which helps with package resolution and compatibility in the project. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]"peer": trueproperty from some dependencies where it was no longer needed. [1] [2] [3] [4] [5] [6]yamlpackage entry frompackage-lock.json, possibly as a cleanup of unused or unnecessary dependencies.Frontend navigation refactor:
Navbarcomponent (frontend/src/components/Navigation/Navbar/Navbar.tsx) to use theLinkcomponent from React Router for navigation instead of<a>tags, ensuring client-side routing and preventing full page reloads. [1] [2] [3]Before
Screen.Recording.2025-11-16.at.2.59.28.AM.mov
After
Screen.Recording.2025-11-16.at.3.03.33.AM.mov
Summary by CodeRabbit