-
-
Notifications
You must be signed in to change notification settings - Fork 40
feat: add token-based WebSocket authentication (#25) #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+278
−39
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,5 @@ count.txt | |
| .output | ||
| .vinxi | ||
| todos.json | ||
| tokens.json | ||
| SPEC.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| import crypto from 'crypto'; | ||
| import fs from 'fs'; | ||
| import path from 'path'; | ||
|
|
||
| interface TokenEntry { | ||
| token: string; | ||
| createdAt: number; | ||
| lastUsed: number; | ||
| } | ||
|
|
||
| const TOKENS_FILE = path.resolve('./src/tokens.json'); | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| const EXPIRY_MS = 10 * 24 * 60 * 60 * 1000; // 10 days | ||
|
|
||
| let tokens: TokenEntry[] = []; | ||
|
|
||
| function load(): void { | ||
| try { | ||
| if (fs.existsSync(TOKENS_FILE)) { | ||
| tokens = JSON.parse(fs.readFileSync(TOKENS_FILE, 'utf-8')); | ||
| } | ||
| } catch { | ||
| tokens = []; | ||
| } | ||
| } | ||
|
|
||
| function save(): void { | ||
| try { | ||
| fs.writeFileSync(TOKENS_FILE, JSON.stringify(tokens, null, 2)); | ||
| } catch (e) { | ||
| console.error('Failed to persist tokens:', e); | ||
| } | ||
| } | ||
|
|
||
| function purgeExpired(): void { | ||
| const now = Date.now(); | ||
| const before = tokens.length; | ||
| tokens = tokens.filter(t => (now - t.lastUsed) < EXPIRY_MS); | ||
| if (tokens.length !== before) save(); | ||
| } | ||
|
|
||
| /** Constant-time string comparison to prevent timing attacks. */ | ||
| function timingSafeEqual(a: string, b: string): boolean { | ||
| if (a.length !== b.length) return false; | ||
| try { | ||
| return crypto.timingSafeEqual(Buffer.from(a), Buffer.from(b)); | ||
| } catch { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Store a token upon successful connection. | ||
| * If it already exists, refresh its lastUsed timestamp. | ||
| */ | ||
| export function storeToken(token: string): void { | ||
| purgeExpired(); | ||
| const existing = tokens.find(t => timingSafeEqual(t.token, token)); | ||
| if (existing) { | ||
| existing.lastUsed = Date.now(); | ||
| } else { | ||
| const now = Date.now(); | ||
| tokens.push({ token, createdAt: now, lastUsed: now }); | ||
| } | ||
| save(); | ||
| } | ||
|
|
||
| /** Check if a token is already known/stored on the server. */ | ||
| export function isKnownToken(token: string): boolean { | ||
| purgeExpired(); | ||
| return tokens.some(t => timingSafeEqual(t.token, token)); | ||
| } | ||
|
|
||
| /** Refresh the lastUsed timestamp for a token. */ | ||
| export function touchToken(token: string): void { | ||
| const entry = tokens.find(t => timingSafeEqual(t.token, token)); | ||
| if (entry) { | ||
| entry.lastUsed = Date.now(); | ||
| // Persist periodically — save only if >60s since last save | ||
| // to avoid excessive disk I/O on every message | ||
| } | ||
| } | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /** Check if any tokens exist yet (first-run detection). */ | ||
| export function hasTokens(): boolean { | ||
| purgeExpired(); | ||
| return tokens.length > 0; | ||
| } | ||
|
|
||
| /** Generate a cryptographically random token. */ | ||
| export function generateToken(): string { | ||
| return crypto.randomUUID(); | ||
| } | ||
|
|
||
| // Load persisted tokens on startup | ||
| load(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.