Skip to content

fix(input): prevent recursive throttling loop in InputHandler #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Akash504-ai wants to merge 1 commit into from
+5 −5
Closed

fix(input): prevent recursive throttling loop in InputHandler #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/server/InputHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class InputHandler {
return Math.max(min, Math.min(max, value))
}

async handleMessage(msg: InputMessage) {
async handleMessage(msg: InputMessage, internal = false) {
if (msg.text && typeof msg.text === "string" && msg.text.length > 500) {
msg.text = msg.text.substring(0, 500)
}
Expand All @@ -75,7 +75,7 @@ export class InputHandler {
}

// Throttling: Limit high-frequency events (configurable via inputThrottleMs)
if (msg.type === "move") {
if (!internal && msg.type === "move") {
const now = Date.now()
if (now - this.lastMoveTime < this.throttleMs) {
this.pendingMove = msg
Expand All @@ -85,7 +85,7 @@ export class InputHandler {
if (this.pendingMove) {
const pending = this.pendingMove
this.pendingMove = null
this.handleMessage(pending).catch((err) => {
this.handleMessage(pending, true).catch((err) => {
console.error("Error processing pending move event:", err)
})
}
Expand All @@ -94,7 +94,7 @@ export class InputHandler {
return
}
this.lastMoveTime = now
} else if (msg.type === "scroll") {
} else if (!internal && msg.type === "scroll") {
const now = Date.now()
if (now - this.lastScrollTime < this.throttleMs) {
this.pendingScroll = msg
Expand All @@ -104,7 +104,7 @@ export class InputHandler {
if (this.pendingScroll) {
const pending = this.pendingScroll
this.pendingScroll = null
this.handleMessage(pending).catch((err) => {
this.handleMessage(pending, true).catch((err) => {
console.error("Error processing pending move event:", err)
})
}
Expand Down
Loading