Skip to content

fix: fixed broken workflow#820

Merged
M4dhav merged 1 commit into
AOSSIE-Org:devfrom
Mayank4352:workflow
Jun 18, 2026
Merged

fix: fixed broken workflow#820
M4dhav merged 1 commit into
AOSSIE-Org:devfrom
Mayank4352:workflow

Conversation

@Mayank4352

Copy link
Copy Markdown
Contributor

Description

Fixed broken workflow

Fixes #819

Type of change

  • Bug fix (non-breaking CHANGE which fixes an issue)

How Has This Been Tested?

Tested Locally

Checklist:

  • My code follows the style guidelines of this project
  • [x} I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@Mayank4352 Mayank4352 requested a review from M4dhav as a code owner June 13, 2026 11:15
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Welcome @Mayank4352!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4051797f-2b0b-4ec6-881d-b890ae85a451

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mayank4352 Mayank4352 self-assigned this Jun 15, 2026
@Mayank4352 Mayank4352 added gsoc Part of Google Summer of Code season bug Something isn't working labels Jun 15, 2026

android:exported="true"
android:launchMode="singleInstance"
android:launchMode="singleTop"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change? If I remember correctly, this was required to run the Callkit Plugin.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SingleInstance forces Main Activity to be alone in its task, so any activity it launches (image_picker, file_picker) goes into a separate task which cancels the operation immediately which is why audio/image upload was failing silently.

Call Kit doesn't actually need it on MainActivity the full-screen/lock-screen incoming-call UI is why the plugin recommends on the readme to do launchMode="singleInstance". but in our case accept/decline routing goes through flutter's Call-kit implementation's .event() , none of which depends on MainActivity's launch mode in our case.

So, singleTop keeps calls working and fixes uploads. Despite of this, I've manually tested the call functionality and it is working as intended.

@M4dhav M4dhav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@M4dhav M4dhav linked an issue Jun 18, 2026 that may be closed by this pull request
@M4dhav

M4dhav commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@Mayank4352 Please use more descriptive PR Descriptions and titles in the future

@M4dhav

M4dhav commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

#822 , #824 and #827 depend on this, so please answer the comment and then we can proceed with the others as well.

@Mayank4352

Copy link
Copy Markdown
Contributor Author

@Mayank4352 Please use more descriptive PR Descriptions and titles in the future

Okay, will change

@Mayank4352 Mayank4352 requested a review from M4dhav June 18, 2026 10:24
@M4dhav M4dhav merged commit 5e0bad7 into AOSSIE-Org:dev Jun 18, 2026
3 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

PR Closed - Thank You, @Mayank4352!

  • If this PR was merged: Congratulations! Your contribution is now part of the project. 🚀
  • If this PR was closed without merging: Don’t worry! You can always improve it and submit again. 💪

We appreciate your effort and look forward to more contributions from you! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gsoc Part of Google Summer of Code season

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow broken due to missing dependency

2 participants