fix: fixed broken workflow#820
Conversation
|
🎉 Welcome @Mayank4352!
We appreciate your contribution! 🚀 |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| android:exported="true" | ||
| android:launchMode="singleInstance" | ||
| android:launchMode="singleTop" |
There was a problem hiding this comment.
Why the change? If I remember correctly, this was required to run the Callkit Plugin.
There was a problem hiding this comment.
SingleInstance forces Main Activity to be alone in its task, so any activity it launches (image_picker, file_picker) goes into a separate task which cancels the operation immediately which is why audio/image upload was failing silently.
Call Kit doesn't actually need it on MainActivity the full-screen/lock-screen incoming-call UI is why the plugin recommends on the readme to do launchMode="singleInstance". but in our case accept/decline routing goes through flutter's Call-kit implementation's .event() , none of which depends on MainActivity's launch mode in our case.
So, singleTop keeps calls working and fixes uploads. Despite of this, I've manually tested the call functionality and it is working as intended.
|
@Mayank4352 Please use more descriptive PR Descriptions and titles in the future |
Okay, will change |
|
✅ PR Closed - Thank You, @Mayank4352!
We appreciate your effort and look forward to more contributions from you! 🤝 |
Description
Fixed broken workflow
Fixes #819
Type of change
How Has This Been Tested?
Tested Locally
Checklist:
Maintainer Checklist