Skip to content

fix: Make project links clickable and open in new tab (Fixes #441) #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Riyanshverma wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −2
Open

fix: Make project links clickable and open in new tab (Fixes #441) #502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42b836a
add Facebook icon and link to social media section
Riyanshverma Dec 13, 2025
f4b327b
Revert "add Facebook icon and link to social media section"
Riyanshverma Dec 13, 2025
2ea5f76
refactor: update project link to be a clickable anchor element
Riyanshverma Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/pages/projects.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,16 @@ const Cards = () => {
</Typography>
</CardContent>
<CardActions sx={{ justifyContent: 'center' }}>
<p className="relative z-10 mt-6 flex text-md font-semibold font-mono text-zinc-600 transition group-hover:text-[#00843D] dark:group-hover:text-yellow-400 dark:text-zinc-200">
<a
href={project.link.href}
target="_blank"
rel="noopener noreferrer"
className="relative z-10 mt-6 flex text-md font-semibold font-mono text-zinc-600 transition hover:text-[#00843D] dark:hover:text-yellow-400 dark:text-zinc-200 items-center"
style={{ textDecoration: 'none' }}
>
<LinkIcon className="h-6 w-6 flex-none scale-110" />
<span className="ml-2">{project.link.label}</span>
</p>
</a>
Comment on lines +86 to +95
Copy link

@coderabbitai coderabbitai bot Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Critical: PR references wrong issue number.

The PR title claims to fix issue #441, but according to the PR objectives, issue #441 is about implementing a footer section with navigation links, social media handles, and contact information. This PR actually fixes non-clickable project links on the Projects page, which is unrelated to footer implementation. Please update the PR to reference the correct issue number.

🤖 Prompt for AI Agents 
In src/pages/projects.jsx around lines 86 to 95 the PR incorrectly references
issue #441 in its title/body while the change actually fixes non-clickable
project links on the Projects page; update the PR metadata to reference the
correct issue for this bug (locate the issue that tracks "non-clickable project
links" or create one if missing), change the PR title and description to mention
that issue number, update any closing keywords (e.g., "Fixes #<correct-number>")
so GitHub links it properly, and amend the commit message or changelog entry if
necessary to reflect the correct issue reference.

</CardActions>
</MuiCard>
</Grid>
Expand Down