-
Notifications
You must be signed in to change notification settings - Fork 322
feat: Add consistent hover effects to all card components (#461) #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…#461) - Add transform/transition/hover classes to Card component - Add matching hover effects to CardHome component - Add hover effects to CardEffect component - Add CSS-in-JS hover styles to MUI cards in ideas page - Add CSS-in-JS hover styles to MUI cards in projects page All cards now have consistent hover behavior with: - Subtle lift (translateY) - Scale effect (1.02x) - Enhanced shadow on hover Closes AOSSIE-Org#461
|
@mohit200008 is attempting to deploy a commit to the AOSSIE Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughMultiple Card components and two pages had Tailwind CSS utility classes added to their root/link wrappers to enable transform, transition, scale, translate, and shadow hover effects. No structural, logic, or public API changes were made. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/CardEffect.jsx (1)
5-5: Consider usingshadow-lgfor consistency.The hover effect implementation looks good. However, note that
shadow-xlis used here while other card components (Card.jsx,CardHome.jsx) useshadow-lg. For visual consistency across the application, consider aligning the shadow size.🔎 Proposed change for consistency
- <a className="group relative block h-[22rem] max-lg:w-72 max-xl:w-60 w-72 cursor-pointer transform transition duration-200 ease-out hover:-translate-y-1 hover:scale-[1.02] hover:shadow-xl"> + <a className="group relative block h-[22rem] max-lg:w-72 max-xl:w-60 w-72 cursor-pointer transform transition duration-200 ease-out hover:-translate-y-1 hover:scale-[1.02] hover:shadow-lg">
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/components/Card.jsxsrc/components/CardEffect.jsxsrc/components/CardHome.jsxsrc/pages/ideas/index.jsxsrc/pages/projects.jsx
🔇 Additional comments (4)
src/pages/projects.jsx (1)
46-50: LGTM! Smooth hover interaction added.The transform and box-shadow transitions provide a polished hover effect. The use of GPU-accelerated transforms ensures smooth performance.
src/components/CardHome.jsx (1)
5-5: LGTM! Consistent hover effect implementation.The Tailwind transform and transition classes are applied correctly, and the shadow size (
shadow-lg) is consistent with other card components.src/pages/ideas/index.jsx (1)
27-31: LGTM! Consistent with projects page implementation.The hover effect matches the implementation in
projects.jsx, providing a cohesive user experience across card components.src/components/Card.jsx (1)
19-19: LGTM! Clean implementation with proper class merging.The hover effects are correctly applied using
clsxto merge with any additional classes passed via props, ensuring flexibility while maintaining the consistent hover behavior.
- Changed hover:shadow-xl to hover:shadow-lg to match other card components - Addresses code review feedback for visual consistency
Closes #461
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.