-
Notifications
You must be signed in to change notification settings - Fork 322
Replace Twitter icons with X logo across the website #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@akshitamodi is attempting to deploy a commit to the AOSSIE Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe Footer component updates its social media branding by replacing the Twitter icon import with the X (formerly Twitter) icon, and adjusts the corresponding link label and text accordingly. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/Footer.jsx (1)
48-50: Inconsistent formatting compared to other social links.The X/Twitter link is formatted across multiple lines (48-50) while the other social links above (lines 36-47) are consistently formatted as single-line components. Consider reformatting for consistency.
🔎 Suggested formatting for consistency
- <Link aria-label="Follow on X" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'> - <FontAwesomeIcon icon={faXTwitter} size='xl' /> -</Link> - + <Link aria-label="Follow on X" className=' text-zinc-400 hover:text-[#00843D] dark:text-zinc-400 dark:hover:text-yellow-400 transition' href='https://twitter.com/aossie_org'> + <FontAwesomeIcon icon={faXTwitter} size='xl' /> + </Link>
| import { FontAwesomeIcon } from '@fortawesome/react-fontawesome' | ||
| import { faEnvelope } from '@fortawesome/free-solid-svg-icons' | ||
| import { faDiscord, faGithub, faGitlab, faTwitter } from '@fortawesome/free-brands-svg-icons' | ||
| import { faDiscord, faGithub, faGitlab, faXTwitter } from '@fortawesome/free-brands-svg-icons' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
cat package.json | jq '.dependencies["@fortawesome/free-brands-svg-icons"], .devDependencies["@fortawesome/free-brands-svg-icons"]'Repository: AOSSIE-Org/website
Length of output: 75
🏁 Script executed:
cat src/components/Footer.jsxRepository: AOSSIE-Org/website
Length of output: 2879
Update @fortawesome/free-brands-svg-icons dependency to ^6.4.2 or later; faXTwitter requires version 6.4.2+.
The current constraint ^6.2.1 in package.json allows installation of versions 6.2.1–6.4.1, which do not include the faXTwitter icon. Update the dependency to ^6.4.2 to guarantee support.
Additionally, the X social link uses href='https://twitter.com/aossie_org' but should be updated to https://x.com/aossie_org to align with the rebranding and aria-label. Also standardize the formatting of this Link component to match the style of other social links above it.
🤖 Prompt for AI Agents
In src/components/Footer.jsx around line 6, the file imports faXTwitter which
requires @fortawesome/free-brands-svg-icons v6.4.2+, and the X link is still
pointing to twitter.com plus formatting differs; update package.json to set
"@fortawesome/free-brands-svg-icons": "^6.4.2" (then run install), change the
Link href from "https://twitter.com/aossie_org" to "https://x.com/aossie_org",
ensure the aria-label matches ("X — aossie_org" or similar), and refactor the
Link JSX to match the same formatting/style as the other social links in this
component for consistency.
Updated all Twitter icons to the new X logo while keeping existing social media links unchanged.
This pull request updates all instances of the outdated Twitter bird icon on the website to the official X logo, ensuring brand consistency across all pages and components.
This change improves the visual accuracy and professionalism of the website while maintaining existing functionality.
This contribution demonstrates attention to UI/UX consistency and following current branding standards.
Closes #519
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.