Skip to content

Conversation

@sinuscosinustan
Copy link
Contributor

FRM exposes the amount of coupons and points via /getResourceSink and allows to monitor the total amount of points per minute with rate.

@AP-Hunt
Copy link
Owner

AP-Hunt commented Dec 27, 2024

Hi @sinuscosinustan, thanks for the contribution, I appreciate the time and effort that's gone in. If you can address the linting failure I'd be happy to approve and merge this.

FRM exposes the amount of coupons and points via `/getResourceSink`
and allows to monitor the total amount of points per minute with `rate`.

Signed-off-by: Tan Siewert <[email protected]>
@sinuscosinustan
Copy link
Contributor Author

@AP-Hunt done

@AP-Hunt AP-Hunt merged commit b174427 into AP-Hunt:main Dec 30, 2024
2 checks passed
@sinuscosinustan sinuscosinustan deleted the add-resource-sink branch December 30, 2024 17:45
@AP-Hunt
Copy link
Owner

AP-Hunt commented Dec 30, 2024

@sinuscosinustan Thanks again for the contribution. I've cut a new release with your changes: 1.3.2

@featheredtoast
Copy link
Collaborator

@sinuscosinustan just following up, there are two sink types, one for resources and one for exploration. 1.3.3 addresses this and splits the metrics with a sink_type label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants