ci: add Dockerfile and ghcr upload workflow #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Nah it probably makes sense to push an image through this repo. Github registries make sense to utilize too. Mine are on dockerhub mostly from familiarity (and so everything was in |
matthiasemde
force-pushed
the
add-dockerfile-and-upload-to-ghcr
branch
from
6f4bb54 to
3baea56
Compare
Owner
|
Thanks for putting this together. I agree it's a sensible option, since folks are using this alongside a containerised dedicated server. |
Owner
|
@matthiasemde I'm not sure why the linting is failing, given you've not changed any Go files. Could you take a look, please? |
Contributor
Author
|
@AP-Hunt I ran |
Owner
|
All good from me, I'll merge this. Apologies for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Dockerfile + github workflow to automatically create docker images on releases and push them to the github docker registry.
@featheredtoast, I hope I am not stepping on your toes since you already uploaded an image to your account 😬
I tested the workflow on my fork and it worked fine. However it's a bit difficult to test the actual release mechanism until you actually merge the PR.