Migrate to Tauri V2#10
Conversation
| # The `_lib` suffix may seem redundant but it is necessary | ||
| # to make the lib name unique and wouldn't conflict with the bin name. | ||
| # This seems to be only an issue on Windows, see https://github.com/rust-lang/cargo/issues/8519 | ||
| name = "ark_drop_desktop_lib" |
There was a problem hiding this comment.
Better to keep ark_drop_lib name, because the lib will be shared across different platforms, including Android and iOS devices. And maybe even browsers if we compile it to WebAssembly.
| @@ -0,0 +1,182 @@ | |||
| use anyhow::{anyhow, Result}; | |||
There was a problem hiding this comment.
Do we need these 2 lines from Alvi's PR?
Prevents additional console window on Windows in release, DO NOT REMOVE!!
#![cfg_attr(not(debug_assertions), windows_subsystem = "windows")]
There was a problem hiding this comment.
This is now on src-tauri/src/main.rs: https://github.com/ARK-Builders/ARK-Drop-Desktop/blob/3d8a92dc09ab9fe9b28b269f5760cc451b96ca6b/src-tauri/src/main.rs#L1C1-L2C67
| tauri::Builder::default() | ||
| .plugin(tauri_plugin_clipboard_manager::init()) | ||
| .plugin(tauri_plugin_dialog::init()) | ||
| .plugin(tauri_plugin_opener::init()) |
| handle.await.unwrap(); | ||
| } | ||
|
|
||
| let outpath = dirs::download_dir().unwrap(); |
There was a problem hiding this comment.
Should we provide a default value for None case?
There was a problem hiding this comment.
I'm not sure. I didn't fully review this file, just copied from the current version
|
Looks good, let's fix minor issues and CI. |
2 participants
No description provided.