Skip to content

Conversation

@mberry
Copy link

@mberry mberry commented Oct 1, 2023

Will try parse with http://
If that fails will raise an error

Closes:

mberry added 2 commits October 1, 2023 12:46
Will try parse with http://
If that fails will raise an error
@mberry
Copy link
Author

mberry commented Oct 1, 2023

So the build.yaml script is also running a lint script through pnpm

This should probably be an entirely separate CI script for linting/format as the build is outputting a binary, not source code.

Anyway because of this:

-use url::{Url, ParseError};
+use url::{ParseError, Url};

the build failed, I will fix it and push again.

@kirillt
Copy link
Member

kirillt commented Oct 2, 2023

Probably we should try parsing with https, too:

1.mp4

Also weird little bug (separate issue):

2.mp4

@kirillt kirillt assigned mberry and rizary and unassigned mberry Oct 16, 2023
@rizary
Copy link

rizary commented Jan 21, 2024

I'm planning to work on this after finish #50, what's the context of this issue? we can just put github.com instead https://github.com/ right?

@kirillt
Copy link
Member

kirillt commented Jan 21, 2024

@rizary I'm not sure. Does a link without scheme really can be queried? I guess, it defaults either to http or to https..

@kirillt kirillt changed the title Allow urls without schemes #33, #40: Allow urls without schemes Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants