fix a small bug of the copying history samples in taps_5-8 processing of FIRF32 #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of history samples being copied in arm_fir_f32_5_8_mve should be numTaps-1 (see the file head comment and arm_fir_f32_1_4_mve as reference). So, the "blkCnt = numTaps" should be changed to "blkCnt = numTaps -1". However, to save cycles, I'd rather to change the next line from "blkCnt > 0" to "blkCnt > 1". This has passed the tests and the cycles reduced indeed.
In fact, the vectorization can be used here to achieve more performance uplift but there will be a little code size increase. So I'd just request this small change this time.