Skip to content

fix: mac dir delete#885

Merged
acabarbaye merged 3 commits into
masterfrom
fix-mac-dir-delete
May 29, 2026
Merged

fix: mac dir delete#885
acabarbaye merged 3 commits into
masterfrom
fix-mac-dir-delete

Conversation

@phawxby
Copy link
Copy Markdown
Contributor

@phawxby phawxby commented May 29, 2026

Description

Fixes an issue on Mac where using Unlink on a directory results in an EPERM error, which prevents following on to the Remove which does work ok.

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

File delete

name = "node_modules/stale.txt"
err = nil
unlinkErr = nil
removeErr = nil

Dir delete

name = "node_modules"
err = nil
unlinkErr = error(*fmt.wrapError) *{msg: "conflict: operation not permitted", err: error(*errors.errorString) *{s: "conflict"}}
removeErr = nil

@phawxby phawxby changed the title Fix mac dir delete fix: mac dir delete May 29, 2026
@phawxby phawxby marked this pull request as ready for review May 29, 2026 08:49
Comment thread utils/filesystem/extendedosfs.go
@acabarbaye acabarbaye merged commit 011d599 into master May 29, 2026
7 checks passed
@acabarbaye acabarbaye deleted the fix-mac-dir-delete branch May 29, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants