🐛 Ensure that there is an explicit check that a path is not a directory before unlinking#886
Closed
joshjennings98 wants to merge 2 commits into
Closed
🐛 Ensure that there is an explicit check that a path is not a directory before unlinking#886joshjennings98 wants to merge 2 commits into
joshjennings98 wants to merge 2 commits into
Conversation
…ry before unlinking
acabarbaye
reviewed
May 29, 2026
| err = commonerrors.IgnoreCorrespondTo(err, "is a directory") | ||
| info, err := c.Stat(name) | ||
| if err != nil { | ||
| err = ConvertFileSystemError(err) |
Contributor
There was a problem hiding this comment.
if error is notFound the error should be ignored
acabarbaye
requested changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that there is an explicit check that a path is not a directory before unlinking.
The check for an error with
"is a directory"(EISDIR) is not robust enough. On MacOS, the error isERPERMwhich means thatRemovefails tests on MacOS.Test Coverage