Add support for the Ascon family of algorithms#297
Merged
Conversation
MarcusJGStreets
approved these changes
Sep 16, 2025
Contributor
MarcusJGStreets
left a comment
There was a problem hiding this comment.
Seems to be the obvious shape.
gilles-peskine-arm
requested changes
Oct 14, 2025
Contributor
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM except for a concern about HMAC.
I've only read the pull request and the NIST specification, I have never implemented Ascon.
e91fcb8 to
ea17af3
Compare
gilles-peskine-arm
requested changes
Oct 17, 2025
Contributor
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
Mostly LGTM but the HMAC block size discussion isn't quite right.
Contributor
Author
|
I think I've managed to remove the misleading discussion on 'small input-block sizes', and replace it with more accurate text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for all four algorithms defined in NIST SP800-232.
It uses the new API merged in #253.
Fixes #60