Add support for BLAKE2 algorithms#339
Merged
Merged
Conversation
athoelke
added
enhancement
gilles-peskine-arm
requested changes
Feb 16, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
Mostly LGTM, with a couple of questions and suggestions.
gilles-peskine-arm
requested changes
Apr 13, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM except for HMAC
github-project-automation
Bot
moved this from In Progress
to Done
in PSA Certified API development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One aspect of the PR that I would like feedback on:
Does it make sense to have a single BLAKE2 key type for both BLAKE2s and BLAKE2b MAC algorithms?
Fixes #333