cleanup(linux-app): localize CLI state in BSA and SBSA apps#371
Merged
Conversation
Remove Linux app CLI state leakage from the BSA and SBSA driver-interface layers by passing print and rule-selection inputs explicitly instead of reading them through app globals. This keeps the userspace CLI state local to the app entry files, reduces cross-file coupling, and tightens the PCBSA app main state where it was clearly local, without changing driver behavior. - pass BSA and SBSA print, skip-DP-NIC-MS, and rule-selection inputs explicitly into the driver-interface helpers - remove BSA and SBSA driver-interface dependence on app-level extern globals - localize BSA and SBSA CLI state in the app main files - keep legacy cross-file skip-list and software-view globals unchanged where other Linux app objects still rely on them - tighten obvious file-local state in pcbsa_app_main.c without changing the PCBSA driver interface Change-Id: Icc39be47a775015e8e5d16f461875ee42b9cd269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Linux app CLI state leakage from the BSA and SBSA driver-interface layers by passing print and rule-selection inputs explicitly instead of reading them through app globals. This keeps the userspace CLI state local to the app entry files, reduces cross-file coupling, and tightens the PCBSA app main state where it was clearly local, without changing driver behavior.
Change-Id: Icc39be47a775015e8e5d16f461875ee42b9cd269