added ZipFile instead of using raw p7zip_jll, still not completely re… #13
Conversation
…moved. All tests pass now.
Codecov Report
@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 95.24% 95.30% +0.06%
==========================================
Files 9 9
Lines 463 469 +6
==========================================
+ Hits 441 447 +6
Misses 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| mktempdir() do tmpdir | ||
| cd(tmpdir) | ||
| tmpdir = mktempdir() | ||
| cd(tmpdir) do |
| EzXML = "8f5d6c58-4d21-5cfd-889c-e3ad7ee6a615" | ||
| FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549" | ||
| Images = "916415d5-f1e6-5110-898d-aaa5f9f070e0" | ||
| Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" |
There was a problem hiding this comment.
Pkg can be removed then?
There was a problem hiding this comment.
haven't fully removed p7zip_jll usage yet, just the minimum to make the tests pass.
| using ZipFile | ||
| using DataStructures | ||
|
|
||
| import Tables |
There was a problem hiding this comment.
At line 11, we can remove import Pkg.PlatformEngines: exe7z ?
There was a problem hiding this comment.
haven't fully removed p7zip_jll usage yet, just the minimum to make the tests pass.
There was a problem hiding this comment.
with ZipFile though, you don't need to write files to disk, but would need to rethink a bit more of the structure of the code.
There was a problem hiding this comment.
let's leave this idea for another version. We could leave this PR open for now, or open an issue instead.
|
We switched to ZipArchives.jl in #31, so closing this PR |
3 participants
…moved.
All tests pass now.