Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ dev:
dagster_version: 1.8.4
docker_root: .
dockerfile: ./Dockerfile
docker_env_vars:
- "VAR=SECRET"
- "RANDOM_VAR_IN_CURRENT_ENV"
environment: dev
kubernetes_context: "my-kubernetes-context"
namespace: dagster-dev
Expand Down
1 change: 1 addition & 0 deletions dagster_uc/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class UserCodeDeploymentsConfig:
limits: dict[str, str]
requests: dict[str, str]
kubernetes_context: str
docker_env_vars: list[str]
dagster_gui_url: str | None = None
verbose: bool = False
use_az_login: bool = True
Expand Down
2 changes: 2 additions & 0 deletions dagster_uc/manage_user_code_deployments.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ def build_push_container(
tag=tag,
branch_name=branch_name,
use_az_login=config.use_az_login,
build_envs=config.docker_env_vars if config.docker_env_vars is not None else [],
)


Expand Down Expand Up @@ -145,6 +146,7 @@ def optional_prompt(text: str) -> str | None:
dagster_version=typer.prompt(
"Version of dagster in project (should mirror dagster depoyment!)",
),
docker_env_vars=[],
user_code_deployment_env_secrets=[],
user_code_deployment_env=[],
cicd=typer.confirm(
Expand Down
4 changes: 4 additions & 0 deletions dagster_uc/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ def build_and_push(
tag: str,
branch_name: str,
use_az_login: bool,
build_envs: list[str],
):
"""Build a docker image and push it to the registry"""
# We need to work from the root of the repo so docker can access all files
Expand All @@ -168,6 +169,9 @@ def build_and_push(
".",
]

for env_var in build_envs:
cmd.extend(["--env", env_var])

if use_sudo:
cmd = ["sudo"] + cmd

Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[project]
name = "dagster-uc"
version = "0.3.4"
version = "0.3.5"
authors = [
{name = "Stefan Verbruggen"},
{name = "Stefan Verbruggen"},
{name = "Ion Koutsouris"},
]
description = "CLI for managing user code deployments of a Dagster instance that was deployed on kubernetes."
Expand Down