Skip to content

BUGFIX: fix delete deployment overriding configmap #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 8, 2025
Merged

BUGFIX: fix delete deployment overriding configmap #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ea74ec1
Adding configuration to create new namespace or not
Sep 30, 2025
77d7190
Added config entry to control automatic creation of name space due to…
Oct 3, 2025
ac977ed
minor fix
Oct 3, 2025
dad59f2
Figured out exact location that needed to be fixed for Config map.
Oct 3, 2025
6d0b34a
added image_pull_secrets to init_config
Oct 3, 2025
df2311e
ruff format + version bump
Oct 6, 2025
0491293
minor ruff fix
Oct 6, 2025
3f8a137
fixes for delete deployment overritng secrets
Oct 6, 2025
c0f5589
Fixes for issues where updating the config map either by adding or re…
Oct 6, 2025
db7838e
minor ruff format
Oct 6, 2025
22134d6
Merge remote-tracking branch 'upstream/main' into bugfix-fix-delete-d…
Oct 6, 2025
97a6398
Version Bump
Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions dagster_uc/uc_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,12 @@ def maybe_create_user_deployments_configmap(self) -> None:
dagster_user_deployments_values_yaml_configmap["metadata"]["name"] = (
self.config.user_code_deployments_configmap_name
)
BASE_CONFIGMAP_DATA["imagePullSecrets"] = self.config.image_pull_secrets
base_copy = deepcopy(BASE_CONFIGMAP_DATA)
base_copy["imagePullSecrets"] = self.config.image_pull_secrets
dagster_user_deployments_values_yaml_configmap["data"]["yaml"] = yaml.dump(
BASE_CONFIGMAP_DATA,
base_copy,
)

ConfigMap(
resource=dagster_user_deployments_values_yaml_configmap,
namespace=self.config.namespace,
Expand All @@ -72,10 +74,12 @@ def remove_all_deployments(self) -> None:
from copy import deepcopy

dagster_user_deployments_values_yaml_configmap = deepcopy(BASE_CONFIGMAP)
default_map = deepcopy(BASE_CONFIGMAP_DATA)
default_map["imagePullSecrets"] = self.config.image_pull_secrets

dagster_user_deployments_values_yaml_configmap["data"]["yaml"] = yaml.dump(
BASE_CONFIGMAP_DATA,
default_map,
)

configmap = self._read_namespaced_config_map(
self.config.user_code_deployments_configmap_name,
)
Expand Down Expand Up @@ -411,7 +415,7 @@ def _modify_user_deployments(
logging.debug(f"List of currently configured deployments:\n{depl_list_str}\n\n")
new_configmap_data = deepcopy(BASE_CONFIGMAP_DATA)
new_configmap_data["deployments"] = current_deployments

new_configmap_data["imagePullSecrets"] = self.config.image_pull_secrets
new_configmap = deepcopy(BASE_CONFIGMAP)
new_configmap["data"]["yaml"] = yaml.dump(new_configmap_data)

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "dagster-uc"
version = "0.5.4"
version = "0.5.5"
authors = [
{name = "Stefan Verbruggen"},
{name = "Ion Koutsouris"},
Expand Down
Loading