Skip to content

fix: set name in metadata #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: set name in metadata #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d73763
fix: set name in metadata
ion-elgreco Nov 28, 2024
7a74131
chore: bump version
ion-elgreco Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dagster_uc/uc_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def maybe_create_user_deployments_configmap(self) -> None:
from copy import deepcopy

dagster_user_deployments_values_yaml_configmap = deepcopy(BASE_CONFIGMAP)
dagster_user_deployments_values_yaml_configmap["name"] = (
dagster_user_deployments_values_yaml_configmap["metadata"]["name"] = (
self.config.user_code_deployments_configmap_name
)
dagster_user_deployments_values_yaml_configmap["data"]["yaml"] = yaml.dump(
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "dagster-uc"
version = "0.2.0"
version = "0.2.1"
authors = [{name = "Stefan Verbruggen", email="[email protected]"}, {name = "Ion Koutsouris"}]
description = "CLI for managing user code deployments of a Dagster instance that was deployed on kubernetes."
readme = "README.md"
Expand Down