Conversation
jakobj
approved these changes
Sep 5, 2022
Member
jakobj
left a comment
jakobj
left a comment
There was a problem hiding this comment.
awesome, thanks! 🚀
left a comment that should be addressed before merging
| json.dump(pwdb, pwdb_file) | ||
|
|
||
| def pwhash(password): | ||
| def pwhash(password, salt): |
Member
There was a problem hiding this comment.
in this implementation, the pwhash function needs to be "aware" of the fact that you're using hashing. could you think of a way to avoid this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a random number generator as salt