Skip to content

solution for local maxima with plateau#2

Open
jozsarato wants to merge 1 commit intoASPP:masterfrom
jozsarato:testpablojozsef
Open

solution for local maxima with plateau#2
jozsarato wants to merge 1 commit intoASPP:masterfrom
jozsarato:testpablojozsef

Conversation

@jozsarato
Copy link

@jozsarato jozsarato commented Sep 6, 2022

No description provided.

pberkes
pberkes requested changes Sep 6, 2022
View reviewed changes
hands_on/local_maxima/local_maxima.py
# print(find_maxima(x))

#if __name__ == '__main__':
#main()
Copy link
Contributor

@pberkes pberkes Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove dead code 💀

@pberkes
Copy link
Contributor

pberkes commented Sep 6, 2022

Tests are missing

@pberkes
Copy link
Contributor

pberkes commented Sep 7, 2022

I think the solution would fail this test:

def test_local_maxima_not_a_plateau():
    values = [1, 2, 2, 3, 1]
    expected = [3]
    maxima = local_maxima(values)
    assert maxima == expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pberkes pberkes pberkes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jozsarato @pberkes