UDS-1998: feat(components-core): added close functionality when clicking an anchor in the Anchor menu #1529
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hor in the Anchor menu UDS-1998
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1529/index.html |
davidornelas11
requested changes
May 2, 2025
|
I added a commit to this PR since the coding format can be a little tricky when it comes to providing a working solution for both bootstrap and react. (using isReact and isBootstrap variables) |
|
Scotts changes work for closing the anchor menu but I think the original issue is that the top of the section should be in view when clicking the anchor link. Ive noticed we have the id set to the section instead of the heading on webspark. This might be an issue for webspark as well but this pr looks good after removing the components-core code |
davidornelas11
previously approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(components-core): added close functionality when clicking an anchor in the Anchor menu
UDS-1998
Description
Checklist
Important Reminders
Links