chore: add precommit hook and update linted files #1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1534/index.html |
There was a problem hiding this comment.
I was thinking this hook would be a pre-push hook. (can we include tests too? it will save us from pushing a failed build to jenkins)
Sometimes while developing locally I just want to commit my changes. I may have code I know is not ready for a PR but I need to make a checkpoint.
We should as much as possible make sure all paths are covered.
git commit calls the hook
yarn commit or calling cz does not call prepare-commit-msg
| exit 1 | ||
| else | ||
| echo "Adding linted files to staging..." | ||
| git add . |
There was a problem hiding this comment.
We do not want to add all files, in an automatic way without the contributor knowing. This should be the developers choice to include changes.
- It is possible for a contributor to have changes they do not want to include with the commit.
- I think this prevents contributor from making smaller commits to group similar changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add precommit hook and update linted files
Checklist
Links