Skip to content

UDS-2051: feat(unity-bootstrap-theme): added siteimprove feedback #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
+42 −36
Open

UDS-2051: feat(unity-bootstrap-theme): added siteimprove feedback #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cb527f
feat(unity-bootstrap-theme): added siteimprove feedback
juanmitriatti Aug 29, 2025
3365043
Merge branch 'dev' into UDS-2051
davidornelas11 Oct 7, 2025
e15adb5
chore(unity-bootstrap-theme): rEmove labelledby from div's without ro…
davidornelas11 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/unity-bootstrap-theme/stories/atoms/sidebar/sidebar.templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const SidebarComponent = () => (
<div
id="cardBodyOne"
className="collapse card-body"
aria-labelledby="cardOne"

data-bs-parent=".sidebar"
>
<a href="#" className="nav-link">
Expand Down Expand Up @@ -94,7 +94,7 @@ export const SidebarComponent = () => (
<div
id="cardBodyTwo"
className="collapse card-body"
aria-labelledby="cardTwo"

data-bs-parent=".sidebar"
>
<a href="#" className="nav-link">
Expand Down Expand Up @@ -154,7 +154,7 @@ export const SidebarComponent = () => (
<div
id="cardBodyThree"
className="collapse card-body"
aria-labelledby="cardThree"

data-bs-parent=".sidebar"
>
<a href="#" className="nav-link">
Expand Down
6 changes: 3 additions & 3 deletions packages/unity-bootstrap-theme/stories/atoms/sidebar/sidebar.templates.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const Sidebar = () => (
<div
id="cardBodyOne"
className="collapse card-body"
aria-labelledby="cardOne"

data-bs-parent=".sidebar"
>
<a href="#" className="nav-link">
Expand Down Expand Up @@ -101,7 +101,7 @@ export const Sidebar = () => (
<div
id="cardBodyTwo"
className="collapse card-body"
aria-labelledby="cardTwo"

data-bs-parent=".sidebar"
>
<a href="#" className="nav-link">
Expand Down Expand Up @@ -161,7 +161,7 @@ export const Sidebar = () => (
<div
id="cardBodyThree"
className="collapse card-body"
aria-labelledby="cardThree"

data-bs-parent=".sidebar"
>
<a href="#" className="nav-link">
Expand Down
2 changes: 1 addition & 1 deletion ...y-bootstrap-theme/stories/atoms/universal-nav-link/universal-nav-link.examples.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const DropdownLink = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-one-col"

>
<div className="dropdown-col">
<a
Expand Down
8 changes: 4 additions & 4 deletions ...ges/unity-bootstrap-theme/stories/docs/global-header/navbar-options.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The maximum number of links recommended in any one column is eight.
Dropdown
<span className="fa fa-chevron-down"></span>
</a>
<div className="dropdown-menu dropdown-columns" aria-labelledby="dropdown-one-col">
<div className="dropdown-menu dropdown-columns" >
<div className="dropdown-col">
<a className="dropdown-item" href="#">Navigation Link</a>
<a className="dropdown-item" href="#">Another Link</a>
Expand All @@ -44,7 +44,7 @@ The two column dropdown variant adds a second `.dropdown-col` to the `.dropdown-
Dropdown
<span className="fa fa-chevron-down"></span>
</a>
<div className="dropdown-menu dropdown-columns" aria-labelledby="dropdown-one-col">
<div className="dropdown-menu dropdown-columns" >
<div className="dropdown-col">
<a className="dropdown-item" href="#">Link</a>
<a className="dropdown-item" href="#">Link</a>
Expand Down Expand Up @@ -90,7 +90,7 @@ The three column variant of a mega menu looks like this:
Mega Menu (3 col)
<span className="fa fa-chevron-down"></span>
</a>
<div className="dropdown-menu" aria-labelledby="megamenu-three-col">
<div className="dropdown-menu" >
<div className="container">
<div className="row">
<div className="col-lg">
Expand Down Expand Up @@ -144,7 +144,7 @@ It is also possible to define a set of call to action buttons that correspond to
The same rules apply for the button sizes and alllowed colors. A maximum of two buttons should be used in this space.

```
<div className="dropdown-menu" aria-labelledby="dont-forget-aria-rules">
<div className="dropdown-menu" >
<div className="container">
<div className="row">
...
Expand Down
4 changes: 4 additions & 0 deletions ...nity-bootstrap-theme/stories/molecules/card-and-image/card-and-image.templates.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export const LeftFloatedCard = ({ left }) => {
return (
<div
className={`uds-card-and-image ${left ? "" : "uds-card-and-image-right"}`}
role="image"
aria-hidden="true"
style={{
backgroundImage: `linear-gradient(180deg, #19191900 0%, #191919c9 100%), url('${imageName.hero02}')`,
}}
Expand Down Expand Up @@ -70,6 +72,8 @@ export const RightFloatedCard = ({ left }) => {
return (
<div
className={`uds-card-and-image ${left ? "" : "uds-card-and-image-right"}`}
role="image"
aria-hidden="true"
style={{
backgroundImage: `linear-gradient(180deg, #19191900 0%, #191919c9 100%), url('${imageName.hero02}')`,
}}
Expand Down
2 changes: 2 additions & 0 deletions ...heme/stories/molecules/quote-image-background/quote-image-background.templates.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ export default {
export const Default = () => (
<div
className="uds-quote-image-background"
role="image"
aria-hidden="true"
style={{
backgroundImage: `linear-gradient(180deg, #19191900 0%, #191919c9 100%), url('${imageName.hero02}')`,
}}
Expand Down
30 changes: 15 additions & 15 deletions packages/unity-bootstrap-theme/stories/organisms/global-footer/global-footer.templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ export const TwoColumns = () => (
<div
id="footlink-two"
className="collapse accordion-body"
aria-labelledby="footlink-header-two"

>
<a className="nav-link" href="#" title="link">
Biological and Health Systems Computing
Expand Down Expand Up @@ -1228,7 +1228,7 @@ export const ThreeColumns = () => (
<div
id="footlink-two"
className="collapse accordion-body"
aria-labelledby="footlink-header-two"

>
<a className="nav-link" href="#" title="link">
Biological and Health Systems Computing
Expand Down Expand Up @@ -1271,7 +1271,7 @@ export const ThreeColumns = () => (
<div
id="footlink-three"
className="collapse accordion-body"
aria-labelledby="footlink-header-three"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -1574,7 +1574,7 @@ export const FourColumns = () => (
<div
id="footlink-two"
className="collapse accordion-body"
aria-labelledby="footlink-header-two"

>
<a className="nav-link" href="#" title="link">
Biological and Health Systems Computing
Expand Down Expand Up @@ -1617,7 +1617,7 @@ export const FourColumns = () => (
<div
id="footlink-three"
className="collapse accordion-body"
aria-labelledby="footlink-header-three"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -1665,7 +1665,7 @@ export const FourColumns = () => (
<div
id="footlink-four"
className="collapse accordion-body"
aria-labelledby="footlink-header-four"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -1968,7 +1968,7 @@ export const FiveColumns = () => (
<div
id="footlink-two"
className="collapse accordion-body"
aria-labelledby="footlink-header-two"

>
<a className="nav-link" href="#" title="link">
Biological and Health Systems Computing
Expand Down Expand Up @@ -2011,7 +2011,7 @@ export const FiveColumns = () => (
<div
id="footlink-three"
className="collapse accordion-body"
aria-labelledby="footlink-header-three"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -2059,7 +2059,7 @@ export const FiveColumns = () => (
<div
id="footlink-four"
className="collapse accordion-body"
aria-labelledby="footlink-header-four"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -2107,7 +2107,7 @@ export const FiveColumns = () => (
<div
id="footlink-five"
className="collapse accordion-body"
aria-labelledby="footlink-header-five"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -2410,7 +2410,7 @@ export const SixColumns = () => (
<div
id="footlink-two"
className="collapse accordion-body"
aria-labelledby="footlink-header-two"

>
<a className="nav-link" href="#" title="link">
Biological and Health Systems Computing
Expand Down Expand Up @@ -2453,7 +2453,7 @@ export const SixColumns = () => (
<div
id="footlink-three"
className="collapse accordion-body"
aria-labelledby="footlink-header-three"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -2501,7 +2501,7 @@ export const SixColumns = () => (
<div
id="footlink-four"
className="collapse accordion-body"
aria-labelledby="footlink-header-four"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -2549,7 +2549,7 @@ export const SixColumns = () => (
<div
id="footlink-five"
className="collapse accordion-body"
aria-labelledby="footlink-header-five"

>
<a className="nav-link" href="#" title="link">
Student Organization
Expand Down Expand Up @@ -2597,7 +2597,7 @@ export const SixColumns = () => (
<div
id="footlink-six"
className="collapse accordion-body"
aria-labelledby="footlink-header-six"

>
<a className="nav-link" href="#" title="link">
A Zen master
Expand Down
20 changes: 10 additions & 10 deletions packages/unity-bootstrap-theme/stories/organisms/global-header/global-header.templates.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export const Basic = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-one-col"

>
<div className="dropdown-col">
<a
Expand Down Expand Up @@ -560,7 +560,7 @@ export const DropDownMenus = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-one-col"

>
<div className="dropdown-col">
<a
Expand Down Expand Up @@ -627,7 +627,7 @@ export const DropDownMenus = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-two-col"

>
<div className="dropdown-col">
<h3>Column One</h3>
Expand Down Expand Up @@ -748,7 +748,7 @@ export const DropDownMenus = () => (
</a>
<div
className="dropdown-menu"
aria-labelledby="megamenu-three-col"

>
<div className="container">
<div className="row">
Expand Down Expand Up @@ -892,7 +892,7 @@ export const DropDownMenus = () => (
</a>
<div
className="dropdown-menu"
aria-labelledby="megamenu-four-col"

>
<div className="container">
<div className="row">
Expand Down Expand Up @@ -1131,7 +1131,7 @@ export const DropDownMenus = () => (
</a>
<div
className="dropdown-menu"
aria-labelledby="megamenu-five-col"

>
<div className="container">
<div className="row">
Expand Down Expand Up @@ -2223,7 +2223,7 @@ export const ScrolledState = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-one-col"

>
<div className="dropdown-col">
<a
Expand Down Expand Up @@ -2274,7 +2274,7 @@ export const ScrolledState = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-one-col"

>
<div className="dropdown-col">
<a
Expand Down Expand Up @@ -2325,7 +2325,7 @@ export const ScrolledState = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-one-col"

>
<div className="dropdown-col">
<a
Expand Down Expand Up @@ -2691,7 +2691,7 @@ export const Partner = () => (
</a>
<div
className="dropdown-menu dropdown-columns"
aria-labelledby="dropdown-one-col"

>
<div className="dropdown-col">
<a
Expand Down