M10: ProcessingRunner skeleton by m-cahill · Pull Request #17332 · AUTOMATIC1111/stable-diffusion-webui

m-cahill · 2026-03-12T04:50:30Z

Phase III — Runner & Service Boundary

Introduces ProcessingRunner abstraction as unified execution entrypoint.

Changes:

\modules/runtime/runner.py\ — ProcessingRunner, ProcessingRequest
\process_images\ delegates through runner (internal only)
\ est/quality/test_processing_runner.py\ — contract test

Invariants: Behavior-preserving. Zero blast radius. All callers (UI/API/scripts) unchanged.

Ref: docs/milestones/M10/M10_plan.md

Made with Cursor

- docs/serena.md: Living ledger, phase map, invariants, milestone table - docs/milestones/M00/: M00_plan, preflight, e2e_baseline, ci_inventory, toolcalls - scripts/dev/: run_m00_baseline_e2e.ps1, .sh (thin verification helpers) - Baseline tag baseline-pre-refactor created on 82a973c No runtime/structural changes. Behavior-preserving docs and verification only. Made-with: Cursor

- Add Invariant Registry and Serena Refactor Principles to serena.md - Create M00_run1.md, M00_summary.md, M00_audit.md - Update milestone ledger: M00 Completed - Document CI evidence (Linter pass; Tests fail pre-existing) Made-with: Cursor

Made-with: Cursor

…irmation - Update ledger with CI run IDs 22794525690 (Linter ✓), 22794525698 (Tests ✗) - Refresh M00_summary.md and M00_audit.md per governance closeout - Add M00_run2.md (latest CI analysis) Made-with: Cursor

M00 kickoff baseline e2e

- Remove same-repo PR skip condition (CI runs on all PRs) - Install setuptools before env setup; add --do-not-download-clip - Add pip-audit (non-blocking) before environment setup - Add smoke startup step (verify app boots before full tests) - Add --cov-fail-under=60 coverage threshold - Pin GitHub Actions to commit SHAs - Add .gitattributes for CRLF/LF normalization - Add M01 plan and toolcalls ledger Made-with: Cursor

Made-with: Cursor

Fixes pkg_resources in pip's isolated build env. Build-time fix only. Made-with: Cursor

CLIP fix worked. Git clone of Stability-AI fails without auth. Add token-based URLs for Stability-AI repos. Made-with: Cursor

Made-with: Cursor

- Add --exit handling when --skip-prepare-environment (launch.py) - Setup: python launch.py --skip-prepare-environment --skip-torch-cuda-test --exit - Smoke: python launch.py --skip-prepare-environment --skip-torch-cuda-test --test-server --use-cpu all --exit CI no longer depends on external git clones. Requires repositories cache to be seeded. Made-with: Cursor

Fixes ModuleNotFoundError: torch when using --skip-prepare-environment. Repositories still required from cache for paths.py. Made-with: Cursor

Made-with: Cursor

- Create scripts/dev/create_stub_repos.py to satisfy paths.py assertion and import chain without cloning external repos - Add Create stub repositories step before Setup environment in run_tests - Remove Cache repositories step (stubs are deterministic, no network) Made-with: Cursor

Made-with: Cursor

…onditioner stubs; M01_run3 and M01_summary Made-with: Cursor

…orts Made-with: Cursor

Made-with: Cursor

…Denoiser, BrownianTreeNoiseSampler, trange) Made-with: Cursor

Made-with: Cursor

…nDistribution) Made-with: Cursor

Made-with: Cursor

- Add modules/prompt_seed_prep.py with prepare_prompt_seed_state(p) - Replace inline all_seeds/all_subseeds logic in process_images_inner - Mutate p.seed/p.subseed before call; prepare_prompt_seed_state writes to p - Behavior-preserving: fill_fields_from_opts, setup_prompts unchanged - Phase II runtime seam preparation Made-with: Cursor

Made-with: Cursor

M06: Prompt/seed prep extraction

Made-with: Cursor

docs(M06): closeout — audit, summary, ledger

- Add modules/opts_snapshot.py with create_opts_snapshot(opts) - Capture snapshot in process_images_inner after prepare_prompt_seed_state - Full shallow copy of opts.data via SimpleNamespace - No runtime behavior change; snapshot write-only for M07 Made-with: Cursor

Made-with: Cursor

M07: Opts snapshot introduction

Made-with: Cursor

docs(M07): closeout — run2, audit, summary, ledger, M08 seed

…reads - Replace opts.foo with p.opts_snapshot.foo for safe read-only settings - Migrated: save_images_before_face_restoration, save_images_before_color_correction, samples_format, return_mask, save_mask, return_mask_composite, save_mask_composite, grid_only_if_multiple, return_grid, grid_save, grid_format, grid_extended_filename - Leave save_samples(), sample_hr_pass(), create_infotext(), metadata on shared.opts - Behavior-preserving; no change to save paths or naming Made-with: Cursor

Made-with: Cursor

M08: Opts Snapshot Threading (continued)

Made-with: Cursor

…mpt and RefactorSummaryPrompt Made-with: Cursor

docs(M08): closeout — run2, audit, summary, ledger, M09 seed

Made-with: Cursor

- Add modules/runtime_context.py with RuntimeContext dataclass - Attach p.runtime_context in process_images_inner() after opts_snapshot - Write-only: no migration of shared.* reads yet - Completes Phase II runtime seam preparation Made-with: Cursor

Made-with: Cursor

M09: Execution Context Introduction

Made-with: Cursor

- Add modules/runtime/runner.py with ProcessingRunner and ProcessingRequest - Wire process_images to delegate through runner (internal only) - Add test/quality/test_processing_runner.py contract test Behavior-preserving. Zero blast radius. All callers unchanged. Made-with: Cursor

Made-with: Cursor

m-cahill added 30 commits March 6, 2026 19:17

docs(M00): fix ledger commit SHA to cdfe128

d0efa18

Made-with: Cursor

docs(M00): ledger final commit d0efa18

9aa37b3

Made-with: Cursor

Merge pull request #1 from m-cahill/m00-kickoff-baseline-e2e

aa47cf7

M00 kickoff baseline e2e

M01: Add PIP_NO_BUILD_ISOLATION to fix CLIP pkg_resources in build env

cb4b152

Made-with: Cursor

M01: Add --no-build-isolation to clip install in launch_utils

9ae7626

Fixes pkg_resources in pip's isolated build env. Build-time fix only. Made-with: Cursor

M01: Add GITHUB_TOKEN for repo clones, cache repositories

23575dc

CLIP fix worked. Git clone of Stability-AI fails without auth. Add token-based URLs for Stability-AI repos. Made-with: Cursor

M01: Revert GITHUB_TOKEN (Repository not found). Document run analysis.

f2db027

Made-with: Cursor

M01: Add Install runtime dependencies step (torch, clip, requirements)

6963719

Fixes ModuleNotFoundError: torch when using --skip-prepare-environment. Repositories still required from cache for paths.py. Made-with: Cursor

docs(M01): M01_run2 analysis - paths assert, cache seeding required

1bbc0f4

Made-with: Cursor

M01: add LatentDiffusion stub to ddpm.py for sd_models_types import

b80ec79

Made-with: Cursor

M01: add ldm.util stub (default) for sd_hijack_optimizations

623a665

Made-with: Cursor

M01: add ldm/sgm attention, diffusionmodules, midas stubs

9f4cecb

Made-with: Cursor

M01: add sgm.models.diffusion stub

1d3c4dc

Made-with: Cursor

M01: add sgm denoiser_scaling, discretizer, DiffusionEngine, GeneralC…

bc3bd81

…onditioner stubs; M01_run3 and M01_summary Made-with: Cursor

ci(M01): fix sgm.modules.attention attribute - explicit submodule imp…

28d006b

…orts Made-with: Cursor

ci(M01): expose sgm.modules.diffusionmodules.model and openaimodel

e280ac5

Made-with: Cursor

ci(M01): add k_diffusion.sampling stubs (get_sigmas_*, torch)

f1a2fd9

Made-with: Cursor

ci(M01): add k_diffusion.utils stub

123a9d2

Made-with: Cursor

ci(M01): add k_diffusion.external and sampling stubs (DiscreteEpsDDPM…

feca86b

…Denoiser, BrownianTreeNoiseSampler, trange) Made-with: Cursor

ci(M01): explicitly import k_diffusion submodules in __init__

afe4956

Made-with: Cursor

ci(M01): add ldm.modules.distributions.distributions (DiagonalGaussia…

e988b21

…nDistribution) Made-with: Cursor

ci(M01): explicitly import ldm.modules.distributions in __init__

e023946

Made-with: Cursor

ci(M01): add ldm.modules.diffusionmodules.openaimodel stub

80b305b

Made-with: Cursor

ci(M01): explicitly import ldm.modules.diffusionmodules in __init__

f013e55

Made-with: Cursor

m-cahill added 27 commits March 9, 2026 22:41

docs(M05): update M05_run2 with Quality success (22888808682)

0654b9a

Made-with: Cursor

docs(M05): closeout — summary, audit, ledger, M06 seed

595ea21

Made-with: Cursor

docs(M06): add M06_run1.md CI analysis, toolcalls

0675b33

Made-with: Cursor

Merge pull request #20 from m-cahill/m06-prompt-seed-prep

6744152

M06: Prompt/seed prep extraction

docs(M06): closeout — run2, audit, summary, ledger update

5f54c45

Made-with: Cursor

docs(M07): seed M07 plan and toolcalls scaffold

044e827

Made-with: Cursor

Merge pull request #21 from m-cahill/m07-opts-snapshot

6394067

docs(M06): closeout — audit, summary, ledger

docs(M07): add M07_run1.md CI analysis, toolcalls update

63fa49c

Made-with: Cursor

Merge pull request #22 from m-cahill/m07-opts-snapshot

8ea50d3

M07: Opts snapshot introduction

docs(M07): closeout — run2, audit, summary, ledger, M08 seed

3e59f66

Made-with: Cursor

docs(M07): update toolcalls with closeout steps

c943849

Made-with: Cursor

Merge pull request #23 from m-cahill/m08-snapshot-threading

09a52ac

docs(M07): closeout — run2, audit, summary, ledger, M08 seed

docs(M08): add M08_run1.md CI report and toolcalls

827bc65

Made-with: Cursor

Merge pull request #24 from m-cahill/m08-snapshot-threading

710a0ab

M08: Opts Snapshot Threading (continued)

docs(M08): closeout — run2, audit, summary, ledger, M09 seed

fd363db

Made-with: Cursor

docs(M08): regenerate audit and summary per RefactorMilestoneAuditPro…

fbc8519

…mpt and RefactorSummaryPrompt Made-with: Cursor

Merge pull request #25 from m-cahill/m09-execution-context

82cd17e

docs(M08): closeout — run2, audit, summary, ledger, M09 seed

docs(M09): add full M09 plan

666b159

Made-with: Cursor

docs(M09): update toolcalls log

398e281

Made-with: Cursor

Merge pull request #26 from m-cahill/m09-execution-context

2c6a251

M09: Execution Context Introduction

docs(M09): closeout — run1, run2, audit, summary, ledger

292115c

Made-with: Cursor

docs(M09): update toolcalls log

11b9e0f

Made-with: Cursor

m-cahill requested a review from AUTOMATIC1111 as a code owner March 12, 2026 04:50

M10: Add run1 and toolcalls update

32b16b2

Made-with: Cursor

m-cahill closed this Mar 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

M10: ProcessingRunner skeleton#17332

M10: ProcessingRunner skeleton#17332
m-cahill wants to merge 101 commits intoAUTOMATIC1111:masterfrom
m-cahill:m10-processing-runner

m-cahill commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

m-cahill commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant