Add meta agent option and add continuous action space compatibility to async#297
Merged
Add meta agent option and add continuous action space compatibility to async#297
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds meta-agent support to the ConstellationTasking environment, allowing multiple satellites to be grouped under a single agent that controls them with concatenated observation and action spaces. Additionally, it fixes bugs related to continuous action space handling in async connectors and modernizes the PyTorch policy loading functionality.
- Added meta-agent groupings functionality with observation/action space concatenation
- Fixed continuous action space compatibility issues in async connectors
- Updated PyTorch policy loading to use modern RLModule checkpoint format
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration/test_int_full_environments.py | Added test environment with meta-agent groupings and updated test to cover both regular and meta-agent scenarios |
| src/bsk_rl/utils/rllib/discounting.py | Fixed continuous action space handling with new utility functions and improved NO_ACTION detection |
| src/bsk_rl/utils/rllib/init.py | Modernized PyTorch policy loading to use RLModule checkpoint format instead of legacy approach |
| src/bsk_rl/gym.py | Added core meta-agent implementation with observation/action space concatenation and satellite grouping logic |
Comments suppressed due to low confidence (1)
e01b2b5 to
f17dc71
Compare
d88c656 to
4195ae0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #296
Allows for meta-agents to be created that concatenate the observation and action spaces of the satellites.
Also fixes some bugs in the async connectors for continuous action spaces.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Added tests for meta-agents.
Future Work
None.
Checklist